WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#34011 closed task (blessed) (fixed)

Deprecate force_ssl_login()

Reported by: johnbillion Owned by: johnbillion
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.0
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

Since [28609], force_ssl_login() is just a wrapper for force_ssl_admin() and isn't used in core.

The FORCE_SSL_LOGIN constant could be deprecated too, but there's no need as it just behaves the same as FORCE_SSL_ADMIN.

Attachments (1)

34011.patch (1.3 KB) - added by johnbillion 4 years ago.

Download all attachments as: .zip

Change History (5)

@johnbillion
4 years ago

#1 @johnbillion
4 years ago

  • Keywords has-patch added

#2 @johnbillion
4 years ago

  • Owner set to johnbillion
  • Resolution set to fixed
  • Status changed from new to closed

In 34700:

Deprecate force_ssl_login(), which is simply a wrapper for force_ssl_admin() and is not used in core.

Fixes #34011

#3 @johnbillion
4 years ago

In 34703:

force_ssl_login() has been functionally identical to force_ssl_admin() since 4.0 (#10267), so its test assertions can be removed as the function has been deprecated in [34700]. The remaining assertions suitably cover force_ssl_admin().

See #34011

#4 @DrewAPicture
4 years ago

In 34706:

Docs: Add an @see reference for the "use-instead-of" function in the DocBlock for force_ssl_login(), deprecated in [34700].

See #34011. See #32246.

Note: See TracTickets for help on using tickets.