Opened 10 years ago
Closed 10 years ago
#34027 closed defect (bug) (fixed)
Improve method documentation for WP_Widget_Text
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 4.4 | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | Widgets | Keywords: | good-first-bug has-patch |
| Focuses: | docs | Cc: |
Description
Note: This is part of the effort in #34013 to improve method documentation to all core widget classes
Class: WP_Widget_Text
File: wp-includes/widgets/class-wp-widget-text.php
Attachments (2)
Change History (10)
#1
@
10 years ago
- Keywords has-patch added; needs-patch removed
- Milestone changed from Awaiting Review to 4.4
#2
@
10 years ago
Added patch to improve the method docs for the widget(), update(), form(), and __construct() methods in the WP_Widget_Text class.
#3
@
10 years ago
- Keywords needs-patch added; has-patch removed
Hi @leemon,
Thanks for the patch!
Just a couple of notes:
- Let's go with the vernacular of something like "the current {type} widget instance" instead of "a particular instance of a widget". Being general in the
WP_Widgetbase class is fine, but in this context, we can be more specific. For example:
* Handles updating settings for the current Text widget instance.
- Notice I inserted the type of widget, in this case "Text", and more specifically mentioned updating the settings which is what the
update()method does. - The same sort of advice goes along with any other method in the class
#4
follow-up:
↓ 5
@
10 years ago
Thanks for the clarification, Drew! You may have guessed that I'm a newbie.
Before creating the new patches, I'd like to be sure about the strings to use:
__construct(): Creates a new {type} widget instance.
widget(): Echoes the current {type} widget instance content.
update(): Handles updating settings for the current {type} widget instance.
form(): Outputs the current {type} widget instance settings update form.
What do you think?
#5
in reply to:
↑ 4
@
10 years ago
Replying to leemon:
Thanks for the clarification, Drew! You may have guessed that I'm a newbie.
Before creating the new patches, I'd like to be sure about the strings to use:
__construct(): Creates a new {type} widget instance.
widget(): Echoes the current {type} widget instance content.
update(): Handles updating settings for the current {type} widget instance.
form(): Outputs the current {type} widget instance settings update form.
What do you think?
Works for me :-)
Improve method documentation