Opened 11 years ago
Closed 11 years ago
#34027 closed defect (bug) (fixed)
Improve method documentation for WP_Widget_Text
| Reported by: | DrewAPicture | Owned by: | DrewAPicture |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.4 |
| Component: | Widgets | Version: | |
| Severity: | normal | Keywords: | good-first-bug has-patch |
| Cc: | Focuses: | docs |
Description
Note: This is part of the effort in #34013 to improve method documentation to all core widget classes
Class: WP_Widget_Text
File: wp-includes/widgets/class-wp-widget-text.php
Attachments (2)
Change History (10)
#2
@
11 years ago
Added patch to improve the method docs for the widget(), update(), form(), and __construct() methods in the WP_Widget_Text class.
#3
@
11 years ago
- Keywords needs-patch added; has-patch removed
Hi @leemon,
Thanks for the patch!
Just a couple of notes:
- Let's go with the vernacular of something like "the current {type} widget instance" instead of "a particular instance of a widget". Being general in the
WP_Widgetbase class is fine, but in this context, we can be more specific. For example:
* Handles updating settings for the current Text widget instance.
- Notice I inserted the type of widget, in this case "Text", and more specifically mentioned updating the settings which is what the
update()method does. - The same sort of advice goes along with any other method in the class
#4
follow-up:
↓ 5
@
11 years ago
Thanks for the clarification, Drew! You may have guessed that I'm a newbie.
Before creating the new patches, I'd like to be sure about the strings to use:
__construct(): Creates a new {type} widget instance.
widget(): Echoes the current {type} widget instance content.
update(): Handles updating settings for the current {type} widget instance.
form(): Outputs the current {type} widget instance settings update form.
What do you think?
#5
in reply to: ↑ 4
@
11 years ago
Replying to leemon:
Thanks for the clarification, Drew! You may have guessed that I'm a newbie.
Before creating the new patches, I'd like to be sure about the strings to use:
__construct(): Creates a new {type} widget instance.
widget(): Echoes the current {type} widget instance content.
update(): Handles updating settings for the current {type} widget instance.
form(): Outputs the current {type} widget instance settings update form.
What do you think?
Works for me :-)
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Improve method documentation