WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#34040 closed defect (bug) (fixed)

Multisite - My Sites dropdown should have hover effect for parent menu items

Reported by: Nikschavan Owned by: afercia
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.4
Component: Toolbar Keywords: has-patch commit
Focuses: ui, accessibility, multisite Cc:

Description

In WordPress Multisite, When selecting sites from My Sites dropdown, the parent menu items are not highlighted.

http://i.imgur.com/NnVPp0u.jpg

Attachments (2)

34040.1.diff (636 bytes) - added by Nikschavan 5 years ago.
Patch for the fix
34040.2.diff (1.9 KB) - added by afercia 5 years ago.

Download all attachments as: .zip

Change History (14)

@Nikschavan
5 years ago

Patch for the fix

#1 @Nikschavan
5 years ago

  • Keywords has-patch added

#2 @Nikschavan
5 years ago

  • Summary changed from My Sites dropdown in a Multisite should have hover effect for parent menu items to Multisite - My Sites dropdown should have hover effect for parent menu items
  • Type changed from defect (bug) to enhancement

#4 @johnbillion
5 years ago

  • Keywords reporter-feedback needs-testing added

Which browser and OS are you using? This works fine for me in the latest Firefox and Chrome on OS X.

#5 @Nikschavan
5 years ago

  • Keywords reporter-feedback removed

@johnbillion The above screenshot is from latest chrome in windows 10, same is the result in latest FF.

Meanwhile, the fix is working on latest chrome and FF on windows 10 -

http://i.imgur.com/CdZH4vs.jpg

Will test the patch on more browsers if required.

#6 @Nikschavan
5 years ago

  • Keywords needs-testing removed

#7 @swissspidy
5 years ago

  • Component changed from Networks and Sites to Toolbar
  • Milestone changed from Awaiting Review to 4.4
  • Type changed from enhancement to defect (bug)

I just tested this on Chrome and FF on OS X and can confirm the bug exists. The provided patch fixes the issue.

#8 @DrewAPicture
5 years ago

  • Owner set to afercia
  • Status changed from new to assigned

#9 @afercia
5 years ago

Thanks @Nikschavan! As far as I can see there are two more things we should take care of:

  • the icon color when hovering or focusing the sub items should have the "active" color
  • all the changes here should be done also for the Sass alternate color schemes, see /wp-admin/css/colors/_admin.scss

#10 @Nikschavan
5 years ago

Thank you for a review @afercia, I will refresh my patch with SASS and add hover for the icons as well!

@afercia
5 years ago

#11 @afercia
5 years ago

  • Focuses accessibility added
  • Keywords commit added

Refreshed patch to take care of the icon and color schemes. Screenshot with the patch applied:

https://cldup.com/xbYZsN2_kT.png

#12 @afercia
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 35265:

Multisite: Improve the Admin Bar parent menu items color on hover and focus.

Props Nikschavan for the initial patch.
Fixes #34040.

Note: See TracTickets for help on using tickets.