Opened 9 years ago
Closed 9 years ago
#34040 closed defect (bug) (fixed)
Multisite - My Sites dropdown should have hover effect for parent menu items
Reported by: | Nikschavan | Owned by: | afercia |
---|---|---|---|
Milestone: | 4.4 | Priority: | normal |
Severity: | normal | Version: | 4.4 |
Component: | Toolbar | Keywords: | has-patch commit |
Focuses: | ui, accessibility, multisite | Cc: |
Attachments (2)
Change History (14)
#2
@
9 years ago
- Summary changed from My Sites dropdown in a Multisite should have hover effect for parent menu items to Multisite - My Sites dropdown should have hover effect for parent menu items
- Type changed from defect (bug) to enhancement
#4
@
9 years ago
- Keywords reporter-feedback needs-testing added
Which browser and OS are you using? This works fine for me in the latest Firefox and Chrome on OS X.
#7
@
9 years ago
- Component changed from Networks and Sites to Toolbar
- Milestone changed from Awaiting Review to 4.4
- Type changed from enhancement to defect (bug)
I just tested this on Chrome and FF on OS X and can confirm the bug exists. The provided patch fixes the issue.
#9
@
9 years ago
Thanks @Nikschavan! As far as I can see there are two more things we should take care of:
- the icon color when hovering or focusing the sub items should have the "active" color
- all the changes here should be done also for the Sass alternate color schemes, see
/wp-admin/css/colors/_admin.scss
#10
@
9 years ago
Thank you for a review @afercia, I will refresh my patch with SASS and add hover for the icons as well!
Note: See
TracTickets for help on using
tickets.
Patch for the fix