Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#34048 closed defect (bug) (fixed)

Shiny updates hangs at "Updating…" after updating translations

Reported by: ocean90's profile ocean90 Owned by: ocean90's profile ocean90
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.2
Component: Upgrade/Install Keywords: has-patch 2nd-opinion
Focuses: Cc:

Description

If you're updating a plugin which has translation updates the "Updating…" state doesn't get removed because the Ajax response includes HTML:

<p>Some of your translations need updating. Sit tight for a few more seconds while we update them as well.</p>
<div class="update-messages lp-show-latest"><h4>Updating translations for User Switching (en_CA)&#8230;</h4><p>Downloading translation from <span class="code">https://downloads.wordpress.org/translation/plugin/user-switching/1.0.7/en_CA.zip</span>&#8230;</p>
<p>Unpacking the update&#8230;</p>
<p>Installing the latest version&#8230;</p>
<p>Translation updated successfully.</p>
</div><div class="update-messages lp-show-latest"><h4>Updating translations for User Switching (it_IT)&#8230;</h4><p>Downloading translation from <span class="code">https://downloads.wordpress.org/translation/plugin/user-switching/1.0.7/it_IT.zip</span>&#8230;</p>
<p>Unpacking the update&#8230;</p>
<p>Installing the latest version&#8230;</p>
<p>Translation updated successfully.</p>
</div><div class="update-messages lp-show-latest"><h4>Updating translations for User Switching (ja)&#8230;</h4><p>Downloading translation from <span class="code">https://downloads.wordpress.org/translation/plugin/user-switching/1.0.7/ja.zip</span>&#8230;</p>
<p>Unpacking the update&#8230;</p>
<p>Installing the latest version&#8230;</p>
<p>Translation updated successfully.</p>
</div><div class="update-messages lp-show-latest"><h4>Updating translations for User Switching (nb_NO)&#8230;</h4><p>Downloading translation from <span class="code">https://downloads.wordpress.org/translation/plugin/user-switching/1.0.7/nb_NO.zip</span>&#8230;</p>
<p>Unpacking the update&#8230;</p>
<p>Installing the latest version&#8230;</p>
<p>Translation updated successfully.</p>
</div><div class="update-messages lp-show-latest"><h4>Updating translations for User Switching (ro_RO)&#8230;</h4><p>Downloading translation from <span class="code">https://downloads.wordpress.org/translation/plugin/user-switching/1.0.7/ro_RO.zip</span>&#8230;</p>
<p>Unpacking the update&#8230;</p>
<p>Installing the latest version&#8230;</p>
<p>Translation updated successfully.</p>
</div><div class="update-messages lp-show-latest"><h4>Updating translations for User Switching (ru_RU)&#8230;</h4><p>Downloading translation from <span class="code">https://downloads.wordpress.org/translation/plugin/user-switching/1.0.7/ru_RU.zip</span>&#8230;</p>
<p>Unpacking the update&#8230;</p>
<p>Installing the latest version&#8230;</p>
<p>Translation updated successfully.</p>
</div><script type="text/javascript">
					(function( wp ) {
						if ( wp && wp.updates.decrementCount ) {
							wp.updates.decrementCount( "translation" );
						}
					})( window.wp );
				</script>{"success":true,"data":{"update":"plugin","plugin":"user-switching\/user-switching.php","slug":"user-switching","oldVersion":"Version 1.0.7","newVersion":"Version 1.0.8"}}

Attachments (1)

34048.patch (901 bytes) - added by ocean90 10 years ago.

Download all attachments as: .zip

Change History (6)

#1 @ocean90
10 years ago

  • Owner set to ocean90
  • Status changed from new to reviewing

@ocean90
10 years ago

#2 @ocean90
10 years ago

  • Keywords has-patch added; needs-patch removed

#3 @ocean90
10 years ago

  • Keywords 2nd-opinion added
  • Version changed from 4.3 to 4.2

With 34048.patch we re-use the automatic upgrader skin if the parent upgrader uses it.

@dd32: Could you verify this for me please?

#4 @dd32
10 years ago

@ocean90 I see nothing wrong with this change, although I haven't tested it.

#5 @ocean90
10 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 34748:

Language Upgrader: Re-use the automatic upgrader skin if the parent upgrader is using it.

Prevents broken Ajax responses when Language_Pack_Upgrader::async_upgrade() gets triggered during a shiny update.

Fixes #34048.

Note: See TracTickets for help on using tickets.