`get_page_of_comment()` not limiting query to proper post

[boonebgorges]

[34535] changed get_page_of_comment() so that it uses WP_Comment_Query, but it was done incorrectly. The 'post_ID' parameter of WP_Comment_Query does nothing; it should be 'post_id' instead. (That's a separate mess that ought to be cleaned up at some point.)

Aside from creating incorrect comment pages, this bug is also exhausting resources on blogs with many comments.

[boonebgorges]

In 34660:

Use correct 'page_id' parameter in get_page_of_comment().

See #34057.

[boonebgorges]

In 34661:

In get_page_of_comment(), use a true COUNT query.

This improves memory usage by not compiling a list of comment IDs.

See #34057.

[boonebgorges]

#34050 was marked as a duplicate.

[boonebgorges]

This ought to be fixed.

[knutsp]

@boonebgorges:
Why have comment-page-1/ in almost every comment permalink? This part used not to be present unless comment page > 1. See ​https://make.wordpress.org/core/comments/feed/

I this has not the same cause as what is fixed here, I can open a new ticket.

[boonebgorges]

Replying to knutsp:

@boonebgorges:
Why have comment-page-1/ in almost every comment permalink? This part used not to be present unless comment page > 1. See ​https://make.wordpress.org/core/comments/feed/

I this has not the same cause as what is fixed here, I can open a new ticket.

It's not really the same issue, but it's a legitimate one, and more closely related to #8071. Please open a separate ticket.