Abstract functionality from wp-comments-post.php

[johnbillion]

wp-comments-post.php is a remnant of days gone past and a great example of technical debt. Everything going in is slashed, and every error condition results in an exit, except when it results in a redirect header followed by an exit.

There's not much we can do about this, but what we can do it abstract a bunch of the code into a function, in order to make the actual process of submitting a comment unit testable.

[johnbillion]

34059.diff​ introduces wp_handle_comment_post() which accepts an unslashed array of comment data and returns a WP_Comment or WP_Error object.

Unit tests are in progress.

[johnbillion]

34059.3.diff​ introduces tests for comment posting.

Anyone want to review this?

[johnbillion]

34059.4.diff​ includes updated tests for multisite.

[DrewAPicture]

Only two things that jumped out at me:

• If the ternaries are aligned like that because they started wrapping to new lines, we might as well just do if/else statements. Or initialize the nulls as null and 0s as 0s first, then do if statements to set values from the $comment_data array.
• I think wp_handle_comment_post() might be a little too ambiguous and easily confused with post as in post type instead of post as in $_POST

[johnbillion]

In 34059.5.diff​:

• Renames wp_handle_comment_post() to wp_handle_comment_submission().
• Initialises the $comment_* variables to avoid the ternaries.
• Adds a test for comment content that contains slashes.

I think this is good to go.

[SergeyBiryukov]

assertNotFalse() was throwing a fatal error on PHP 5.2, see [33526], [33846], and [34664] :)

Looks good otherwise.

[SergeyBiryukov]

In 34799:

Abstract functionality from wp-comments-post.php into a function, wp_handle_comment_submission().

Add unit tests.

Props johnbillion.
Fixes #34059.

[SergeyBiryukov]

In 34801:

Add missing unit tests from [34799].

Props johnbillion.
See #34059.