WP_Query zero offset parameter doesn't override paged

[mazurstas]

When offset parameter is set to zero paged parameter is taken into account.

[boonebgorges]

Hi mazurstas - Welcome to Trac! Good catch here.

[boonebgorges]

In 34697:

WP_Query should not ignore an offset of 0.

Props mazurstas.
Fixes #34060.

[westonruter]

I just found that r34697 breaks code that uses get_posts( array( 'paged' => $x ) ) since offset will default to 0 it will always override paged.

This breaks, for instance, the sample code provided at ​https://vip.wordpress.com/documentation/writing-bin-scripts/#faq

[westonruter]

A workaround is to explicitly pass a non-numeric offset, for example:

<?php
$posts = get_posts( array(
    'paged' => $x,
    'offset' => null,
) );

But this is not ideal.

[boonebgorges]

@westonruter offset should not default to 0. By default, it shouldn't be set. Do you have a filter or something else that's setting offset to 0?

[westonruter]

@boonebgorges I'm using get_posts() without 'suppress_filters' => false, and this function has an offset of 0 among its $defaults:

<?php
function get_posts( $args = null ) {
        $defaults = array(
                'numberposts' => 5, 'offset' => 0,  // <========= HERE
                'category' => 0, 'orderby' => 'date',
                'order' => 'DESC', 'include' => array(),
                'exclude' => array(), 'meta_key' => '',
                'meta_value' =>'', 'post_type' => 'post',
                'suppress_filters' => true
        );
        /* ... */

[boonebgorges]

Ah right, get_posts(). (Damn you, get_posts()!) Let me think about this - it might be able to change the default values of get_posts() without breaking backward compatibility.

[boonebgorges]

@westonruter As I suspected, it looks like we can just pull the offset=0 default out of get_posts(). The tests in [34060.diff] should demonstrate that the behavior matches pre-[34697] behavior. Can I ask you to verify?

[westonruter]

Qapla'!

Change in 34060.diff​ offset=>null to be omitted and for paged to be respected.

[boonebgorges]

In 35417:

Don't specify an offset default in get_posts().

The default value should be a null offset. A 0 default overrides any value
of paged passed to get_posts(). See [34697].

Fixes #34060.