WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#34062 closed enhancement (fixed)

The WXR export tool should export terms metadata

Reported by: Chouby Owned by: boonebgorges
Milestone: 4.6 Priority: normal
Severity: normal Version: 4.4
Component: Export Keywords: has-patch
Focuses: Cc:

Description

Now that #10142 introduced the termmeta table, these data should be exported as it is already done for posts. Of course the Import tool should be modified accordingly.

Attachments (2)

34062.patch (5.1 KB) - added by Chouby 5 years ago.
34062-wordpress-importer.diff (4.7 KB) - added by boonebgorges 4 years ago.

Download all attachments as: .zip

Change History (18)

@Chouby
5 years ago

#1 @Chouby
5 years ago

  • Keywords has-patch added

34062.patch introduces a <wp:termmeta> tag and modifies the formatting for other term tags too as keeping everything inline does not look good anymore.

I wonder if we should have separate tags for categories and tags as it is for all other term tags except <wp:term_id>

This ticket was mentioned in Slack in #core by boone. View the logs.


4 years ago

This ticket was mentioned in Slack in #core by boone. View the logs.


4 years ago

#4 @boonebgorges
4 years ago

  • Milestone changed from Awaiting Review to 4.6
  • Owner set to boonebgorges
  • Status changed from new to accepted

Thanks for the patch, @Chouby.

I wonder if we should have separate tags for categories and tags as it is for all other term tags except <wp:term_id>

I'd say no. My understanding is that Category and Tag are only separated out in the WXR because of some historical accidents (tags didn't always exist; custom taxonomies didn't always exist; WXR is based on RSS, where Category and Tag are semantically distinct). I don't think there's a technical reason to make them distinct for the purposes of termmeta.

==

Including termmeta in the WXR export doesn't do much good if the importer doesn't handle termmeta as well. @rmccue is in the process of introducing some Modern Software Development Practices to the importer https://make.wordpress.org/core/2015/11/18/wordpress-importer-redux/, and there is a PR for termmeta support that is waiting for the current ticket to be resolved: https://github.com/humanmade/WordPress-Importer/pull/18. If the new importer is ready by the time 4.6 is released, that PR should be sufficient. If not, we should be sure that a new version of the old wordpress-importer is released with termmeta support. See 34062-wordpress-importer.diff.

I am going to commit the export functionality but leave the ticket open as a reminder that we shouldn't ship it without doing something about import.

#5 @boonebgorges
4 years ago

In 37240:

Include taxonomy term metadata in WXR export.

Because term XML nodes now include termmeta and can thus be much larger, this
changeset also includes adds some newlines and indentation to make the XML
easier to read.

Props Chouby.
See #34062.

This ticket was mentioned in Slack in #core by boone. View the logs.


4 years ago

This ticket was mentioned in Slack in #core by chriscct7. View the logs.


4 years ago

#8 @chriscct7
4 years ago

@boonebgorges is the import feature planned for 4.6, or should it be split off into another ticket for a future release?

#10 @boonebgorges
4 years ago

It looks like the new importer is not going to happen for 4.6, so we should prepare to do a wordpress-importer release. @rmccue Do you want to buddy up on this? This may be a chance to fix a couple of the easy-win importer tickets as well.

#11 follow-up: @lukecavanagh
4 years ago

When was the last update made on the WordPress Importer?

https://wordpress.org/plugins/wordpress-importer/

#12 in reply to: ↑ 11 @DrewAPicture
4 years ago

Replying to lukecavanagh:

When was the last update made on the WordPress Importer?

See https://make.wordpress.org/core/2015/11/18/wordpress-importer-redux/ for what's happening with the importer.

#13 @lukecavanagh
4 years ago

@DrewAPicture

Okay got it, so the redux version will be the one updated as the WordPress Importer on the repo and included in core.

This ticket was mentioned in Slack in #core by ocean90. View the logs.


4 years ago

#15 @ocean90
4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

Closing as fixed and opened #37213 for the importer.

This ticket was mentioned in Slack in #core by netweb. View the logs.


4 years ago

Note: See TracTickets for help on using tickets.