Incorrect site URL in email templates

[ramay]

I've installed wordpress press in another directory and my url to admin page become ​http://mysite.com/my_folder/wp-admin, and my site works from ​http://mysite.com url. In settings page look like that:
WordPress Address (URL) ​http://mysite.com/my_folder
Site Address (URL) ​http://mysite.com

But in email notifications my site url is ​http://mysite.com/my_folder , but must be ​http://mysite.com

[SergeyBiryukov]

Hi @ramay, welcome to Trac!

Could you clarify which email notifications in particular have the incorrect URL?

Does the issue still happen with all plugins disabled and a default theme (Twenty Fifteen) activated?

[ramay]

Replying to SergeyBiryukov:
Yes it's still happen in native wordpress email template (Password Change Notification) at the bottom of email:

*
*
*
Regards,
All at «My site name»
​http://mysite.com/my_folder

It seems that function instead of home_url returns site_url

[SergeyBiryukov]

So, there are 4 instances of that template:

• update_option_new_admin_email()​
• send_confirmation_on_profile_email()​
• wp_update_user(), 1​
• wp_update_user(), 2​

The first two use network_home_url() and appear to be unaffected.

The second two use get_option( 'siteurl' ) and should probably use home_url() instead.

Introduced in [32820].

[tyxla]

Use home_url() for the site URL in the wp_update_user() email notifications.

[tyxla]

+1.
The above patch fixes this issue as @SergeyBiryukov suggested. This addresses the wrong site URL in the user update email notifications in the cases when there is a difference between the site URL (the WordPress Address (URL) option) and home URL (the Site Address (URL) option).

Side note: There are several more occurences of get_option( 'siteurl' ) that might need to be updated to use home_url() as well. IMHO they are worth the investigation.

[johnbillion]

@tyxla a ticket is only closed once it's been committed to core. :)

[tyxla]

Oh, I must have accidentally closed it - sorry about that. I didn't even notice - thanks!

[SergeyBiryukov]

In 34820:

Use home_url() instead of get_option( 'siteurl' ) in notifications that are sent when a user's email address or password is changed.

Props tyxla, ramay.
Fixes #34071.