Opened 8 years ago
Closed 8 years ago
#34080 closed defect (bug) (fixed)
Use wp_star_rating() on Add Themes screen
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.4 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Themes | Keywords: | has-patch has-screenshots |
Focuses: | ui, accessibility, rtl, administration | Cc: |
Description
Background: #26814
Unlike Add Plugins screen, the Add Themes screen does not use wp_star_rating()
and tries to recreate similar markup with JS.
The markup, however, is a bit different, and has a few issues:
- Does not work for RTL (see the before/after screenshots).
- Requires a lot of custom CSS styling.
- Uses different classes and is visually inconsistent with plugin ratings.
- Does not appear to be accessible.
We should add an echo
argument to wp_star_rating()
(like we did for wp_terms_checklist()
in [33904]) and use the existing function instead.
There is a slight visual change (the "based on %s ratings" string becomes redundant, because wp_star_rating()
has a similar text as a title attribute and screen reader text).
Attachments (3)
Change History (8)
Note: See
TracTickets for help on using
tickets.
Related: #meta1266