WordPress.org

Make WordPress Core

Opened 2 years ago

Last modified 6 weeks ago

#34088 new defect (bug)

Add delay to admin menu arrow's disappearance

Reported by: pathartl Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 4.3.1
Component: Administration Keywords: has-patch needs-testing needs-refresh
Focuses: ui Cc:

Description

Currently if you hover over an item in the admin's left sidebar, the submenu will show after a few hundred milliseconds. The arrow/triangle next to the submenu will appear at the exact same time. However, on leaving the hover state, the arrow disappears right away while the submenu will stay around for a few hundred milliseconds and then disappear.

I would assume this is because the arrow is bound to the menu item, and not the submenu. Not really sure what the solution would be to this, but I see it as a bug in code that's improves UX.

https://cldup.com/oDl-qIUYxW.gif

Attachments (4)

34088.diff (1.5 KB) - added by coreymcollins 2 years ago.
Changing active submenu arrow to appear based on parent menu class rather than hover state
34088.1.diff (11.7 KB) - added by coreymcollins 2 years ago.
Update arrow for for other admin color settings including RTL display
34088.2.diff (11.9 KB) - added by darrenlambert 20 months ago.
Corrected file paths
34088.3.diff (784 bytes) - added by abefumito 15 months ago.

Download all attachments as: .zip

Change History (15)

@coreymcollins
2 years ago

Changing active submenu arrow to appear based on parent menu class rather than hover state

#1 @swissspidy
2 years ago

  • Focuses administration removed
  • Keywords has-patch needs-testing added

#2 @afercia
2 years ago

Please consider any change here should also take into account the focus style and the alternate color schemes in the Sass files.

@coreymcollins
2 years ago

Update arrow for for other admin color settings including RTL display

#3 @coreymcollins
2 years ago

Thanks for the mindful eye, @afercia! Here's an example using the Sunrise color scheme in both LTR and RTL displays.

LTR:
https://www.dropbox.com/s/qfkr0yv7qn0hrqm/wp-menu-sunrise-ltr.gif

RTL:
https://www.dropbox.com/s/fjtlg3gq4ln2bxm/wp-menu-sunrise-rtl.gif

#4 @dwainm
2 years ago

  • Keywords needs-refresh added

HI @coreymcollins. I'm unable to apply this patch for testing purposes. Would you mind checking if it can be applied?

I'm using grunt patch command on Varying Vagrant Vagrants.

#5 @coreymcollins
23 months ago

@dwainm This is working fine for me. I applied 34088.1.diff to my branch in Cornerstone and was able to see the changes reflected. I'm not a VVV user, so I can't verify what may be going on there.

Would love for some others to test this as well to see if there may be something funky going on. Thanks!

#6 @darrenlambert
20 months ago

I tried applying the patch and got errors.

For each CSS line update I get the error

error: css/admin-menu-rtl.css: No such file or directory

The problem is the format of the patch file, it seems.

The file paths in patch 34088.1 start wp-admin...

When they should start /src/wp-admin...

I updated the paths, and was able to apply the patch.

I've attached 34088.2.diff

Last edited 20 months ago by darrenlambert (previous) (diff)

@darrenlambert
20 months ago

Corrected file paths

#7 @afercia
20 months ago

Patches should be created from and applied to an install from the trunk repo, which doesn't have .rtl or minified files. They're created later during the build process :) See
https://make.wordpress.org/core/handbook/tutorials/installing-wordpress-locally/#zip-file-svn-or-git
See also the other related sections in the Handbook.

@abefumito
15 months ago

#8 @abefumito
15 months ago

I created 34088.3.diff from src. I tested it works well.

#9 @jmdarts007
2 months ago

  • Severity changed from normal to critical
  • Type changed from defect (bug) to feature request

well pooling test

#10 @melchoyce
2 months ago

  • Severity changed from critical to normal
  • Type changed from feature request to defect (bug)

#11 @salcode
6 weeks ago

At WordCamp Philly 2017 Contributor Day we reviewed patch 34088.3.diff on a LTR install and confirmed the proper behavior on:

  • Chrome Mac Version 61.0.3163.100
  • Safari Version 11.0 (11604.1.38.1.7)
  • Firefox Mac 56.0
  • Internet Explorer 11 on Windows 7
  • Internet Explorer 8 on Windows 7

To clarify "proper behavior", once the cursor left the parent item both the sub-menu and the arrow disappear without any delay.

Our group included: @rynonet, @pbarthmaier, @koakekuna

Last edited 6 weeks ago by salcode (previous) (diff)
Note: See TracTickets for help on using tickets.