WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 3 years ago

#34092 closed enhancement (wontfix)

Introduce Multiple Enclosures for Shortcodes

Reported by: miqrogroove Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Shortcodes Keywords:
Focuses: javascript Cc:

Description

Expand the shortcode syntax to allow HTML attributes between shortcode tags rather than inside of them.

See ​https://make.wordpress.org/core/2015/09/29/shortcode-roadmap-draft-two/

Attachments (5)

34092.diff​ (2.0 KB) - added by miqrogroove 5 years ago.
34092.2.diff​ (2.1 KB) - added by miqrogroove 5 years ago.
Skip enclosure parsing with a strpos check for only one enclosure.
34092.3.diff​ (15.2 KB) - added by miqrogroove 5 years ago.
Improves one term in the shortcode main regexp. Adds unit tests.
34092.4.diff​ (15.6 KB) - added by miqrogroove 5 years ago.
Missed wptexturize.
34092.5.diff​ (15.2 KB) - added by miqrogroove 5 years ago.
Refresh

Download all attachments as: .zip

Change History (10)

@miqrogroove
5 years ago

@miqrogroove
5 years ago

Skip enclosure parsing with a strpos check for only one enclosure.

@miqrogroove
5 years ago

Improves one term in the shortcode main regexp. Adds unit tests.

#1 @miqrogroove
5 years ago

  • Keywords has-patch added; needs-unit-tests removed

@miqrogroove
5 years ago

Missed wptexturize.

@miqrogroove
5 years ago

Refresh

#2 @miqrogroove
5 years ago

There may be additional bug fixes needed for Javascript files, see ​https://wordpress.slack.com/archives/feature-shortcode/p1444072369000020

#3 @miqrogroove
5 years ago

  • Focuses javascript added
  • Keywords has-patch removed

34092.5.diff​ is ready on the PHP side, but needs someone to help port into Javascript.

#4 @miqrogroove
5 years ago

  • Milestone changed from 4.4 to Awaiting Review

Basically every aspect of this feature was rejected at the core meeting today. We might be better off blocking shortcodes that contain HTML. In the meantime, there is no chance this will be ready for 4.4.

#5 @danielbachhuber
3 years ago

  • Keywords roadmap removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Thanks again for all of your hard work on shortcodes, @miqrogroove. I think we can safely close this in favor of Gutenberg blocks.

Note: See TracTickets for help on using tickets.