WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 3 weeks ago

#34101 closed enhancement (maybelater)

Update WP core's jquery-serialize-object script

Reported by: jtsternberg Owned by:
Milestone: Priority: low
Severity: normal Version:
Component: External Libraries Keywords:
Focuses: javascript Cc:

Description

The jquery-serialize-object script bundled with core is both old (2010), and lacks the ability to serialize nested form keys (i.e. name="name[value]").

I suggest we replace with this updated script instead: https://github.com/macek/jquery-serialize-object

Attachments (2)

34101.diff (5.7 KB) - added by jtsternberg 5 years ago.
Replace serialize-object script w/ new and updated script and add minified version.
34101.2.diff (7.9 KB) - added by jtsternberg 5 years ago.
Actually include the minified file this time.

Download all attachments as: .zip

Change History (5)

@jtsternberg
5 years ago

Replace serialize-object script w/ new and updated script and add minified version.

@jtsternberg
5 years ago

Actually include the minified file this time.

#1 @ericlewis
5 years ago

Is this fully backwards compatible?

#2 @ocean90
5 years ago

  • Component changed from Script Loader to External Libraries

#3 @desrosj
3 weeks ago

  • Priority changed from normal to low
  • Resolution set to maybelater
  • Status changed from new to closed

I am going to close this out as a maybelater.

A search of the plugin directory returned 133 matches for jquery-serialize-object. The majority of the plugins have a very low number of active installs. A large number of the plugins matched are either false positives or the plugins including the library suggested in the ticket description themselves.

I'm also changing this to a low priority as jQuery development is not currently a priority. If someone comes across this ticket, would like to see this land in Core, and is willing to dedicate the time, please do reopen. Ideally:

  • some tests would be written to confirm that the change would be 100% seamless and backwards compatible.
  • The package would be installed using NPM for easier updating in the future (though the project is largely untouched in several years)
  • Testing would be done to ensure no adverse affects if a plugin is also rolling their own version of the library.
Note: See TracTickets for help on using tickets.