#34117 closed enhancement (fixed)
Remove unnecessary dynamic portion from the `plugin_action_links` filters
Reported by: | johnbillion | Owned by: | johnbillion |
---|---|---|---|
Milestone: | 4.4 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Plugins | Keywords: | has-patch commit |
Focuses: | docs, administration | Cc: |
Description
The plugin_action_links
and plugin_action_links_{$plugin_file}
filter names are prefixed with network_admin_
in the Network Admin Plugins list table. This makes the documentation for the filters unnecessarily verbose.
Let's remove the dynamic prefix from these filter names and apply the filters individually.
This has the side effect of allowing the @since
docs for the network_admin_*
filters to be corrected.
Attachments (2)
Change History (8)
#1
@
8 years ago
- Keywords has-patch added
- Owner set to DrewAPicture
- Status changed from new to reviewing
#3
@
8 years ago
- Keywords commit added
- Owner changed from DrewAPicture to johnbillion
- Status changed from accepted to assigned
@johnbillion I ended up just indenting the hooks since we're renaming them anyway. Our changelog style for renaming hooks (it's only happened about ~10 times before) is to mark the initial @since
with "As hook_name", which I've done in 34117.2.diff among another minor fixes. Good to go.
34117.diff looks complicated but all it's doing is removing the dynamic
$prefix
portion and replacing it with anif ( $screen->in_admin( 'network' ) ) { ... } else { ... }
statement.Indentation needs correcting before commit.
Drew, mind reviewing?