WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#34126 closed defect (bug) (fixed)

add-textdomain.php misses translate_nooped_plural()

Reported by: johnbillion Owned by: westi
Milestone: 4.5 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch needs-testing
Focuses: Cc:

Description

The tools/i18n/add-textdomain.php script misses instances of translate_nooped_plural(). This function is an exception to the i18n functions in that it should not be considered when generating a POT file (with makepot.php), but should be considered when adding a textdomain.

Attachments (2)

34074.patch (2.5 KB) - added by jrf 4 years ago.
34126.patch (659 bytes) - added by jrf 4 years ago.
The right patch this time…

Download all attachments as: .zip

Change History (8)

@jrf
4 years ago

#1 @jrf
4 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

#2 @johnbillion
4 years ago

  • Keywords needs-patch added; has-patch needs-testing removed

Looks like you uploaded the wrong patch @jrf .

@jrf
4 years ago

The right patch this time...

#3 @jrf
4 years ago

Oh dear, I did indeed... Corrected. Good catch @johnbillion

Last edited 4 years ago by jrf (previous) (diff)

#4 @jrf
4 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

#5 @SergeyBiryukov
4 years ago

  • Milestone changed from Awaiting Review to 4.5

#6 @westi
4 years ago

  • Owner set to westi
  • Resolution set to fixed
  • Status changed from new to closed

In 36390:

i18n tools: Add the text domain to translate_nooped_plural() calls as well.

Fixes #34126 props jrf.

Note: See TracTickets for help on using tickets.