Make WordPress Core

Context Navigation

← Previous Ticket
Next Ticket →

Opened 11 years ago

Closed 10 years ago

#34126 closed defect (bug) (fixed)

add-textdomain.php misses translate_nooped_plural()

Reported by:	johnbillion	Owned by:	westi
Priority:	normal	Milestone:	4.5
Component:	I18N	Version:
Severity:	normal	Keywords:	has-patch needs-testing
Cc:		Focuses:

Description

The tools/i18n/add-textdomain.php script misses instances of translate_nooped_plural(). This function is an exception to the i18n functions in that it should not be considered when generating a POT file (with makepot.php), but should be considered when adding a textdomain.

Attachments (2)

34074.patch (2.5 KB ) - added by jrf 11 years ago.
34126.patch (659 bytes ) - added by jrf 11 years ago.: The right patch this time…

Download all attachments as: .zip

Change History (8)

@jrf
11 years ago

Attachment 34074.patch added

#1 @jrf
11 years ago

Keywords has-patch needs-testing added; needs-patch removed

#2 @johnbillion
11 years ago

Keywords needs-patch added; has-patch needs-testing removed

Looks like you uploaded the wrong patch @jrf .

@jrf
11 years ago

Attachment 34126.patch added

The right patch this time...

#3 @jrf
11 years ago

Oh dear, I did indeed... Corrected. Good catch @johnbillion

Last edited 11 years ago by jrf (previous) (diff)

#4 @jrf
11 years ago

Keywords has-patch needs-testing added; needs-patch removed

#5 @SergeyBiryukov
11 years ago

Milestone Awaiting Review → 4.5

#6 @westi
10 years ago

Owner set to westi
Resolution → fixed
Status new → closed

i18n tools: Add the text domain to translate_nooped_plural() calls as well.

Fixes #34126 props jrf.

Note: See TracTickets for help on using tickets.

Download in other formats: