WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#34129 closed enhancement (wontfix)

Add Blackfire.io to the whitelist of oembed providers

Reported by: romainneutron Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Embeds Keywords: has-patch reporter-feedback
Focuses: Cc:
PR Number:

Description

Hello,

this patch adds Blackfire.io as oEmbed provider to ease Blackfire graphs integration. For example

https://blackfire.io/oembed?url=https%3A//blackfire.io/profiles/ffcffdc1-50db-42bc-bcbb-dcfe86758e26/graph&format=json

Blackfire.io is a young startup that provide very easy-to-use tools for profiling PHP apps. For example, here's the result we propose for a Symfony demo app : https://blackfire.io/profiles/ffcffdc1-50db-42bc-bcbb-dcfe86758e26/graph

We love wordpress and already talked about it: http://blog.blackfire.io/improving-wordpress.html

Regards,

Romain

Attachments (1)

wordpress.patch (1.1 KB) - added by romainneutron 4 years ago.
patch

Download all attachments as: .zip

Change History (3)

@romainneutron
4 years ago

patch

#1 @johnbillion
4 years ago

  • Keywords has-patch reporter-feedback added
  • Version trunk deleted

Thanks for the patch, romainneutron!

As part of our process for whitelisting new oEmbed providers we assess the provider based on a set of standards. Can you take a look at our Whitelisting oEmbed Providers page in the handbook at provide us with answers to the questions please? Also an example of an embeddable URL would help.

Thanks in advance.

Version 0, edited 4 years ago by johnbillion (next)

#2 @johnbillion
4 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Since #32522 just landed, oEmbed providers which provide oEmbed discovery links in their header are now supported by default, and embedding is allowed via a strictly sanitized iframe.

Since this covers Blackfire.io (it includes both application/json+oembed and application/xml+oembed links in its header, thus allowing oEmbed discovery), I'm going to close this as wontfix, particularly because Blackfire.io is a relatively new service and would likely not have been whitelisted at this point anyway.

Yay for oEmbed discovery!

Note: See TracTickets for help on using tickets.