Customizer: Missing comments in Recent Comments widget

[pavelevap]

When you add "Recent Comments" widget in Customizer, you will see only title "Recent comments", but no comments.

[westonruter]

Confirmed. The Recent Comments widget lists comments as expected in 4.3, but in trunk the call to get_comments() in WP_Widget_Recent_Comments::widget() returns an empty array when called in the context of the Customizer preview.

@rachelbaker Any thoughts here?

[rommelxcastro]

hello, after debugging this i have found the issue.

on preview mode on class-wp-widget:344, wp_suspend_cache_addition is defined to true, so when _prime_comment_caches is called on class-wp-comment-query:410 comments can't be added to cache.

[rommelxcastro]

fallback to get_comment

[stevehenty]

Hi @rommelxcastro, I'm seeing comments duplicated in the widget with 34138.patch

[rommelxcastro]

comments duplicated issue fixed

[rommelxcastro]

new patch added, thanks @tevehenty

[wonderboymusic]

I think this touches upon your oeuvre

[stevehenty]

@rommelxcastro with 341381.patch the comments appear correctly.

[boonebgorges]

Good catch. We can simplify this by just calling get_comment(), which will grab from the cache or the database as necessary.

[boonebgorges]

In 35512:

WP_Comment_Query: Fill comment objects from database when cache is unavailable.

This fixes a bug where widgets loaded in a preview or the Customizer are
rendered inside of a wp_suspend_cache_addition() block and thus could not
find comment objects in the cache.

Props rommelxcastro, stevehenty.
Fixes #34138.