Context Navigation

← Previous Ticket
Next Ticket →

#34144 closed defect (bug) (fixed)

`url_to_postid` doesn't recognize URLs with wrong scheme

Reported by:	swissspidy	Owned by:	wonderboymusic
Priority:	normal	Milestone:	4.4
Component:	Rewrite Rules	Version:	1.0
Severity:	normal	Keywords:	has-patch has-unit-tests
Cc:		Focuses:

Description

While working on the oEmbed feature plugin I noticed that url_to_postid doesn't recognize URLs with the wrong URL scheme.

When your site runs HTTPS and you pass a permalink with http://, you won't get the post ID. The same goes when you provide a https:// URL and is_ssl() is false.

A simple set_url_scheme( $url ) fixes this. Patch attached.

Attachments (1)

34144.diff (2.1 KB ) - added by swissspidy 11 years ago.

Download all attachments as: .zip

Change History (5)

@swissspidy
11 years ago

Attachment 34144.diff added

#1 @johnbillion
11 years ago

Keywords has-unit-tests added
Milestone Awaiting Review → Future Release

Previously: #33109

#2 @johnbillion
11 years ago

Milestone Future Release → 4.4

#3 @swissspidy
11 years ago

#33109 was not for this function, but yes, it's kinda related.

#4 @wonderboymusic
11 years ago

Owner set to wonderboymusic
Resolution → fixed
Status new → closed

In 34890:

Rewrite/Permalinks/Canonical: in url_to_postid(), call set_url_scheme() on the URL to combat mixed content issues and find posts cross-scheme.

Adds unit tests.

Props swissspidy.
Fixes #34144.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core