Opened 9 years ago
Last modified 3 years ago
#34149 assigned defect (bug)
Standardize wp-signup.php to also use search engine visibility text
Reported by: | DrewAPicture | Owned by: | DrewAPicture |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | |
Component: | Upgrade/Install | Keywords: | has-patch has-screenshots needs-refresh |
Focuses: | template, multisite | Cc: |
Description
In #27628, we standardized the installation screen to use the same search engine visibility text as the setting in Settings > Reading. We should also change over the text in wp-signup.php. Currently, the option reads as install did before:
Privacy: Allow search engines to index this site. [Yes] [No]
With Twenty Sixteen:
Attachments (10)
Change History (37)
#3
@
9 years ago
I just added a patch to match the setting with Reading Settings
. Please see and let me know if this is going in the right direction?
#4
@
9 years ago
- Keywords has-patch added; needs-patch removed
- Owner set to obenland
- Status changed from new to assigned
Looks good on first glance. I'll take a more in-depth look later today.
#5
@
9 years ago
@grvrulz Thanks for the patch. Can you please attach a screenshot of each default theme with the updated form? I'm sure that it needs some styling.
#7
follow-up:
↓ 11
@
9 years ago
Hey @ocean90
I've attached screenshots with 4 themes, all of which add a border around a fieldset. I don't think the fieldset should be removed(accessibility). Maybe adding some css should help. What do you think?
#8
follow-up:
↓ 10
@
9 years ago
I'd like to see this match #27628 in defaulting to a checked "Allow search engines to index this site" rather than an unchecked "Discourage search engines from indexing this site".
This ticket was mentioned in Slack in #core-multisite by ocean90. View the logs.
9 years ago
#10
in reply to:
↑ 8
@
9 years ago
Replying to jeremyfelt:
I'd like to see this match #27628 in defaulting to a checked "Allow search engines to index this site" rather than an unchecked "Discourage search engines from indexing this site".
Ignore me. I've been misreading quite a bit. :)
#11
in reply to:
↑ 7
;
follow-up:
↓ 12
@
9 years ago
Replying to grvrulz:
Yes, we should add some default styles to wpmu_signup_stylesheet()
.
A start would be
.mu_register fieldset { border: 0; padding: 0, margin: 0 };
Not sure if we need something for p.description
too.
#12
in reply to:
↑ 11
@
9 years ago
Replying to ocean90:
Added a new patch with some styles added for the fieldset, p.description and the checkbox.
#13
@
9 years ago
- Keywords needs-refresh added
after.png I think we should ignore the section headline. It's currently a <label>
element which is only used to mimic the styling.
If has_action( 'blog_privacy_selector' )
returns true the layout is a bit broken, see 34149-broken.png. Wrapping the input with the label seems to solve this.
#14
@
9 years ago
- Keywords commit added; needs-refresh removed
34149.3.patch wraps the inputs in the label elements for the case where blog_privacy_selector
has been hooked.
Screenshots with 34149.3.patch:
Twenty Thirteen:
Twenty Fourteen:
Twenty Fifteen:
Twenty Sixteen:
#15
@
9 years ago
- Keywords commit removed
What about the useless label element which is the same as the screen reader text?
#16
@
9 years ago
@ocean90 OK, let's try 34149.4.patch. I removed the extra label
element and kept the fieldset
. This approach requires style changes for all of the default themes (unless we want labels inside a fieldset to look just like the fieldset legend which looks like labels outside the fieldset.
While this approach is more work, I think it's the right way to go.
I also have a PR prepared for Twenty Sixteen.
Screenshots:
#18
follow-up:
↓ 19
@
9 years ago
@DrewAPicture Do we even need the extra headline visible? Not sure, probably only if blog_privacy_selector
is in use?
#19
in reply to:
↑ 18
@
9 years ago
Replying to ocean90:
@DrewAPicture Do we even need the extra headline visible? Not sure, probably only if
blog_privacy_selector
is in use?
Yes, I think we need the fieldset legend (which isn't "extra") to be visible to match the style of the rest of the form. I can see switching to simply using a label and input for the single option if there's no action, but either way, the label/legend should be visible.
Related/duplicate to the intent of #29305, though this ticket describes the enhancement that will result in the same string being used.