WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 5 months ago

#34149 assigned defect (bug)

Standardize wp-signup.php to also use search engine visibility text

Reported by: DrewAPicture Owned by: DrewAPicture
Milestone: Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: has-patch has-screenshots needs-refresh 4.6-early
Focuses: template, multisite Cc:
PR Number:

Description

In #27628, we standardized the installation screen to use the same search engine visibility text as the setting in Settings > Reading. We should also change over the text in wp-signup.php. Currently, the option reads as install did before:

Privacy:
Allow search engines to index this site.
[Yes] [No]

With Twenty Sixteen:

http://f.cl.ly/items/1C2x3x2W0V0P1C2d3010/Screen%20Shot%202015-10-04%20at%205.03.20%20PM.png

Attachments (10)

34149.patch (2.8 KB) - added by grvrulz 4 years ago.
Initial patch to match site visibility option with reading settings.
2016.png (14.4 KB) - added by grvrulz 4 years ago.
Screenshot with 2016 theme
2015.png (22.8 KB) - added by grvrulz 4 years ago.
Screenshot with 2015 theme
2014.png (12.7 KB) - added by grvrulz 4 years ago.
Screenshot with 2014 theme
2013.png (12.8 KB) - added by grvrulz 4 years ago.
Screenshot with 2013 theme
34149.2.patch (3.3 KB) - added by grvrulz 4 years ago.
Patch with some default styling added.
after.png (38.9 KB) - added by grvrulz 4 years ago.
After the patch on 2015, 2016, and 2014
34149-broken.png (56.4 KB) - added by ocean90 4 years ago.
34149.3.patch (3.2 KB) - added by DrewAPicture 4 years ago.
34149.4.patch (6.2 KB) - added by DrewAPicture 4 years ago.
Remove duplicate text

Download all attachments as: .zip

Change History (36)

#1 @jeremyfelt
4 years ago

  • Milestone changed from Awaiting Review to 4.4

Related/duplicate to the intent of #29305, though this ticket describes the enhancement that will result in the same string being used.

#2 @pavelevap
4 years ago

#29305 was marked as a duplicate.

@grvrulz
4 years ago

Initial patch to match site visibility option with reading settings.

#3 @grvrulz
4 years ago

I just added a patch to match the setting with Reading Settings. Please see and let me know if this is going in the right direction?

#4 @obenland
4 years ago

  • Keywords has-patch added; needs-patch removed
  • Owner set to obenland
  • Status changed from new to assigned

Looks good on first glance. I'll take a more in-depth look later today.

#5 @ocean90
4 years ago

@grvrulz Thanks for the patch. Can you please attach a screenshot of each default theme with the updated form? I'm sure that it needs some styling.

#6 @obenland
4 years ago

  • Owner changed from obenland to ocean90

Turns out, @ocean90 will take a look. :)

@grvrulz
4 years ago

Screenshot with 2016 theme

@grvrulz
4 years ago

Screenshot with 2015 theme

@grvrulz
4 years ago

Screenshot with 2014 theme

@grvrulz
4 years ago

Screenshot with 2013 theme

#7 follow-up: @grvrulz
4 years ago

Hey @ocean90

I've attached screenshots with 4 themes, all of which add a border around a fieldset. I don't think the fieldset should be removed(accessibility). Maybe adding some css should help. What do you think?

#8 follow-up: @jeremyfelt
4 years ago

I'd like to see this match #27628 in defaulting to a checked "Allow search engines to index this site" rather than an unchecked "Discourage search engines from indexing this site".

This ticket was mentioned in Slack in #core-multisite by ocean90. View the logs.


4 years ago

#10 in reply to: ↑ 8 @jeremyfelt
4 years ago

Replying to jeremyfelt:

I'd like to see this match #27628 in defaulting to a checked "Allow search engines to index this site" rather than an unchecked "Discourage search engines from indexing this site".

Ignore me. I've been misreading quite a bit. :)

#11 in reply to: ↑ 7 ; follow-up: @ocean90
4 years ago

Replying to grvrulz:

Yes, we should add some default styles to wpmu_signup_stylesheet().

A start would be

.mu_register fieldset { border: 0; padding: 0, margin: 0 };

Not sure if we need something for p.description too.

@grvrulz
4 years ago

Patch with some default styling added.

#12 in reply to: ↑ 11 @grvrulz
4 years ago

Replying to ocean90:

Added a new patch with some styles added for the fieldset, p.description and the checkbox.

@grvrulz
4 years ago

After the patch on 2015, 2016, and 2014

@ocean90
4 years ago

#13 @ocean90
4 years ago

  • Keywords needs-refresh added

after.png I think we should ignore the section headline. It's currently a <label> element which is only used to mimic the styling.
If has_action( 'blog_privacy_selector' ) returns true the layout is a bit broken, see 34149-broken.png. Wrapping the input with the label seems to solve this.

#14 @DrewAPicture
4 years ago

  • Keywords commit added; needs-refresh removed

34149.3.patch wraps the inputs in the label elements for the case where blog_privacy_selector has been hooked.

Screenshots with 34149.3.patch:

Twenty Thirteen:

http://cl.ly/image/0N3P0X200f2t/34149.3.twentythirteen.png

Twenty Fourteen:

http://cl.ly/image/0d2R36301K3K/34149.3.twentyfourteen.png

Twenty Fifteen:

http://cl.ly/image/2p3G1C313T2e/34149.3.twentyfifteen.png

Twenty Sixteen:

http://cl.ly/image/0s0S3L291Z1v/34149.3.twentysixteen.png

#15 @ocean90
4 years ago

  • Keywords commit removed

What about the useless label element which is the same as the screen reader text?

@DrewAPicture
4 years ago

Remove duplicate text

#16 @DrewAPicture
4 years ago

@ocean90 OK, let's try 34149.4.patch. I removed the extra label element and kept the fieldset. This approach requires style changes for all of the default themes (unless we want labels inside a fieldset to look just like the fieldset legend which looks like labels outside the fieldset.

While this approach is more work, I think it's the right way to go.

I also have a PR prepared for Twenty Sixteen.

Screenshots:

Twenty Thirteen:
http://cl.ly/image/1A0I022d0R3x/34149.4.twentythirteen.png

Twenty Fourteen:
http://cl.ly/image/3S1A2h3i3K1P/34149.4.twentyfourteen.png

Twenty Fifteen:
http://cl.ly/image/1A1D1M1D2O3x/34149.4.twentyfifteen.png

Twenty Sixteen:
http://cl.ly/image/01420M1c3H2B/34149.4.twentysixteen.png

#17 @DrewAPicture
4 years ago

  • Keywords has-screenshots added; good-first-bug removed

#18 follow-up: @ocean90
4 years ago

@DrewAPicture Do we even need the extra headline visible? Not sure, probably only if blog_privacy_selector is in use?

Last edited 4 years ago by ocean90 (previous) (diff)

#19 in reply to: ↑ 18 @DrewAPicture
4 years ago

Replying to ocean90:

@DrewAPicture Do we even need the extra headline visible? Not sure, probably only if blog_privacy_selector is in use?

Yes, I think we need the fieldset legend (which isn't "extra") to be visible to match the style of the rest of the form. I can see switching to simply using a label and input for the single option if there's no action, but either way, the label/legend should be visible.

#20 @wonderboymusic
4 years ago

  • Keywords needs-refresh added

This ticket was mentioned in Slack in #core by wonderboymusic. View the logs.


4 years ago

#22 @ocean90
4 years ago

  • Owner changed from ocean90 to DrewAPicture

It's your call.

#23 @wonderboymusic
4 years ago

  • Milestone changed from 4.4 to Future Release

#24 @jeremyfelt
4 years ago

  • Milestone changed from Future Release to 4.5

This was so close in 4.4, we should be able to wrap it up in 4.5.

#25 @jeremyfelt
4 years ago

  • Milestone changed from 4.5 to Future Release

Going to bump this on to 4.6.

#26 @DrewAPicture
4 years ago

  • Keywords 4.6-early added
Note: See TracTickets for help on using tickets.