Standardize wp-signup.php to also use search engine visibility text

[DrewAPicture]

In #27628, we standardized the installation screen to use the same search engine visibility text as the setting in Settings > Reading. We should also change over the text in wp-signup.php. Currently, the option reads as install did before:

Privacy:
Allow search engines to index this site.
[Yes] [No]

With Twenty Sixteen:

[jeremyfelt]

Related/duplicate to the intent of #29305, though this ticket describes the enhancement that will result in the same string being used.

[pavelevap]

#29305 was marked as a duplicate.

[grvrulz]

Initial patch to match site visibility option with reading settings.

[grvrulz]

I just added a patch to match the setting with Reading Settings. Please see and let me know if this is going in the right direction?

[obenland]

Looks good on first glance. I'll take a more in-depth look later today.

[ocean90]

@grvrulz Thanks for the patch. Can you please attach a screenshot of each default theme with the updated form? I'm sure that it needs some styling.

[obenland]

Turns out, @ocean90 will take a look. :)

[grvrulz]

Screenshot with 2016 theme

[grvrulz]

Screenshot with 2015 theme

[grvrulz]

Screenshot with 2014 theme

[grvrulz]

Screenshot with 2013 theme

[grvrulz]

Hey @ocean90

I've attached screenshots with 4 themes, all of which add a border around a fieldset. I don't think the fieldset should be removed(accessibility). Maybe adding some css should help. What do you think?

[jeremyfelt]

I'd like to see this match #27628 in defaulting to a checked "Allow search engines to index this site" rather than an unchecked "Discourage search engines from indexing this site".

[jeremyfelt]

Replying to jeremyfelt:

I'd like to see this match #27628 in defaulting to a checked "Allow search engines to index this site" rather than an unchecked "Discourage search engines from indexing this site".

Ignore me. I've been misreading quite a bit. :)

[ocean90]

Replying to grvrulz:

Yes, we should add some default styles to wpmu_signup_stylesheet().

A start would be

.mu_register fieldset { border: 0; padding: 0, margin: 0 };

Not sure if we need something for p.description too.

[grvrulz]

Patch with some default styling added.

[grvrulz]

Replying to ocean90:

Added a new patch with some styles added for the fieldset, p.description and the checkbox.

[grvrulz]

After the patch on 2015, 2016, and 2014

[ocean90]

after.png​ I think we should ignore the section headline. It's currently a <label> element which is only used to mimic the styling.
If has_action( 'blog_privacy_selector' ) returns true the layout is a bit broken, see 34149-broken.png​. Wrapping the input with the label seems to solve this.

[DrewAPicture]

34149.3.patch​ wraps the inputs in the label elements for the case where blog_privacy_selector has been hooked.

Screenshots with 34149.3.patch​:

Twenty Thirteen:

Twenty Fourteen:

Twenty Fifteen:

Twenty Sixteen:

[ocean90]

What about the useless label element which is the same as the screen reader text?

[DrewAPicture]

Remove duplicate text

[DrewAPicture]

@ocean90 OK, let's try 34149.4.patch​. I removed the extra label element and kept the fieldset. This approach requires style changes for all of the default themes (unless we want labels inside a fieldset to look just like the fieldset legend which looks like labels outside the fieldset.

While this approach is more work, I think it's the right way to go.

I also have a PR prepared for Twenty Sixteen.

Screenshots:

Twenty Thirteen:

Twenty Fourteen:

Twenty Fifteen:

Twenty Sixteen:

[ocean90]

@DrewAPicture Do we even need the extra headline? Not sure, probably only if blog_privacy_selector is in use?

[DrewAPicture]

Replying to ocean90:

@DrewAPicture Do we even need the extra headline visible? Not sure, probably only if blog_privacy_selector is in use?

Yes, I think we need the fieldset legend (which isn't "extra") to be visible to match the style of the rest of the form. I can see switching to simply using a label and input for the single option if there's no action, but either way, the label/legend should be visible.

[ocean90]

It's your call.

[jeremyfelt]

This was so close in 4.4, we should be able to wrap it up in 4.5.

[jeremyfelt]

Going to bump this on to 4.6.