Error during installation at step 1 - Undefined index: host

[jlambe]

I've setup my local configuration to report all type of errors.

During a fresh installation of WordPress 4.3.1, at Step 1, WordPress triggers an error where the code tries to look at the array key host which is not yet defined.

The error seems to be in the following file: wp-includes/http.php on line 468

Here is a copy of the thrown exception:

Unhandled Exception

Message:

Undefined index: host
Location:

*/wp-includes/http.php on line 468

[jeremyfelt]

Hi @jlambe, thanks for the ticket. I'm not able to confirm any issues in trunk with a fresh install of WordPress and no plugins.

Can you provide steps to replicate the issue?

[jlambe]

Hi @jeremyfelt,

I haven't tested again yet but I have reports that the issue happens only when you choose a language different than default english.

[ramonxd]

Replying to jlambe:

Hi @jeremyfelt,

I haven't tested again yet but I have reports that the issue happens only when you choose a language different than default english.

As @jlambe said, I'm getting the same error when I choose a different language than english.

PS: It looks like a default host option it's not setted.

[ramonxd]

PS: I changed the 466 line in http.php and got it working, even w/ another languages.

//OLD
$same_host = strtolower( $parsed_home['host'] ) === strtolower( $parsed_url['host'] );

//NEW
$same_host = strtolower( $parsed_url['host'] );

[jeremyfelt]

Thanks for the additional info. I'm able to replicate this as well, not sure why the notice wasn't showing before.

When another language is selected during installation, an HTTP request is made to retrieve the language pack. In wp_http_validate_url() we check the host of the URL against the host of the current site to see if it an external request that requires additional validation. We don't take currently take into consideration that no host has been set for the current site yet, so that comparison generates a notice.

A similar issue was fixed via #28648 in [28865]. We should treat this similarly and mark the URL as an external host if no host has yet been set.

[perezlabs]

Added a simple patch based on the solution of @ramonxd and it works well.

[jeremyfelt]

Thanks for the patch @perezlabs. We'll want to keep the comparison between the site's host and the host being parsed. If one is available, it needs to be checked properly. See [28865] for an example approach. If the host is available, check it. If the host is not available, assume it is an external URL.

[perezlabs]

Thanks for the feedback @jeremyfelt.

[swissspidy]

Marking the good first bug as claimed.

[swissspidy]

@jeremyfelt Happy to commit this if it looks good to you :)

[swissspidy]

In 36870:

HTTP: Avoid an undefined index notice in wp_http_validate_url().

Props perezlabs.
Fixes #34164.