WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#34179 closed defect (bug) (fixed)

"Create a New Site" link on My Sites is inconsistent with other "Add New" links

Reported by: helen Owned by: SergeyBiryukov
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: Networks and Sites Keywords: good-first-bug has-screenshots
Focuses: ui, administration, multisite Cc:

Description

http://s.hyhs.me/dScn/image.png

We have a class of .page-title-action (previously .add-new-h2) that's used in many other places, like Posts and Plugins and Themes. This one should be consistent as well. See below for a representative screenshot.

Attachments (4)

Screen Shot 2015-10-06 at 9.26.37 PM.png (22.1 KB) - added by helen 4 years ago.
ms.diff (570 bytes) - added by JeffMatson 4 years ago.
patch.diff (1.4 KB) - added by JeffMatson 4 years ago.
34179.after.png (4.3 KB) - added by SergeyBiryukov 4 years ago.

Download all attachments as: .zip

Change History (10)

@JeffMatson
4 years ago

#1 @JeffMatson
4 years ago

Should be fixed in the above. First patch so bear with me. ;)

This ticket was mentioned in Slack in #core by jeffmatson. View the logs.


4 years ago

#3 @helen
4 years ago

@JeffMatson Thanks for the patch. Notes:

  • The link needs to be moved to be next to the page title, which you should be able to find in wp-admin/my-sites.php.
  • Please create patches from the root of the checkout - patch can't apply the patch without a path and there are often multiple files named the same but in different directories.

@JeffMatson
4 years ago

#4 @JeffMatson
4 years ago

Changes done. If I'm missing anything else, let me know.

#5 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 34979:

My Sites: Make "Create a New Site" link consistent with other "Add New" links.

Props JeffMatson.
Fixes #34179.

#6 @SergeyBiryukov
4 years ago

  • Keywords has-screenshots added; needs-patch removed
  • Milestone changed from Awaiting Review to 4.4
Note: See TracTickets for help on using tickets.