Shortcode JS Missed in r33118

[miqrogroove]

The shortcode attribute parser in Javascript no longer matches the PHP code.

[johnbillion]

34191.2.patch​ abstracts the regex into a function so it can be unit tested to ensure the JS and PHP versions remain consistent.

[miqrogroove]

The new test in 34191.2.patch​ passes for me. If I revert shortcode.js only, the new test fails as expected. Looks good to me.

Do we need to add this kind of test for the main regex as well?

[johnbillion]

In 34933:

Abstract the shortcode attribute parsing regex into its own function, update the JavaScript counterpart, and introduce a test to ensure they do not diverge again.

Fixes #34191
Props miqrogroove, johnbillion

[danielbachhuber]

@miqrogroove Per discussion about adding documentation, shortcode.js (I believe) is used exclusively by mce views https://core.trac.wordpress.org/browser/tags/4.3/src/wp-includes/js/mce-view.js#L670.

I'm not sure how this would be best documented. Comment at the top of the file?

[danielbachhuber]

There are some existing shortcode parsing tests: https://core.trac.wordpress.org/browser/trunk/tests/qunit/wp-includes/js/shortcode.js

I'll update them to cover more cases.