WordPress.org

Make WordPress Core

Opened 2 years ago

Last modified 17 months ago

#34195 new enhancement

Deprecate get_terms_fields

Reported by: wpsmith Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 4.4
Component: Taxonomy Keywords: has-patch
Focuses: Cc:

Description

It seems like most people agree with the removal of this filter. So here is an approach to make this happen.

Attachments (1)

34195.deprecate.get_terms_fields.taxonomy-functions.php.patch (1.8 KB) - added by wpsmith 2 years ago.
deprecate notice for hook.

Download all attachments as: .zip

Change History (5)

#1 @wpsmith
2 years ago

The idea would be that this hook would be deprecated for a while (until a designated version) and eventually completely removed.

#3 @ocean90
17 months ago

  • Component changed from General to Taxonomy
  • Keywords has-patch added

#4 @boonebgorges
17 months ago

  • Milestone changed from Awaiting Review to Future Release

It's definitely a good idea to warn developers that this filter will generally not work.

_deprecated_function() should not be used for this purpose. If nothing else, the way strings are being concatenated cannot properly be translated.

See #10441 for a discussion of _deprecated_hook().

Note: See TracTickets for help on using tickets.