Changes between Initial Version and Version 1 of Ticket #34196, comment 31
- Timestamp:
- 10/31/2015 01:42:27 AM (10 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #34196, comment 31
initial v1 1 1 The patch looks good. Refreshed it a bit after r35464 in 34196.1.patch. 2 2 3 One question: as far as I understand we want the new `medium_large` size to be constant. There is no UI to change it like the other default sizes, and there is no UI to insert it in the editor. However we still store it in the options table, so any plugin or theme can change it or even remove it .3 One question: as far as I understand we want the new `medium_large` size to be constant. There is no UI to change it like the other default sizes, and there is no UI to insert it in the editor. However we still store it in the options table, so any plugin or theme can change it or even remove it (by changing/deleting the options). 4 4 5 5 Wouldn't it be better to "hard-code" it in some way? Maybe in a (private) function that will return all default image sizes (and could be used to reset the users changes to the other default sizes)?