WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#34197 closed enhancement (fixed)

Improve the parameter names and documentation for add_rewrite_rule()

Reported by: johnbillion's profile johnbillion Owned by: johnbillion's profile johnbillion
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: Rewrite Rules Keywords: has-patch
Focuses: docs Cc:

Description

[34708] has highlighted the fact that the parameter names and docblock descriptions for add_rewrite_rule(), WP_Rewrite::add_rule(), and WP_Rewrite::add_external_rule() make no sense.

Attachments (1)

34197.diff​ (5.0 KB) - added by johnbillion 9 years ago.

Download all attachments as: .zip

Change History (3)

@johnbillion
9 years ago

#1 @johnbillion
9 years ago

  • Keywords has-patch added

34197.diff​ changes the name of the $redirect parameter to $query, which is more appropriate, and updates the documentation accordingly.

#2 @johnbillion
9 years ago

  • Owner set to johnbillion
  • Resolution set to fixed
  • Status changed from new to closed

In 34946:

Improve the parameter names and inline documentation for add_rewrite_rule(), WP_Rewrite::add_rule(), and WP_Rewrite::add_external_rule().

Fixes #34197

Note: See TracTickets for help on using tickets.