WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#34203 closed defect (bug) (fixed)

Replace unneeded context with translator comments

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.1
Component: Customize Keywords:
Focuses: Cc:

Description

Background: ​https://wordpress.slack.com/archives/polyglots/p1442850615001279

There are two strings added in [30306] that need a translator comment instead of a context. They are now in WP_Customize_Manager::get_document_title_template()​ after [34269].

_x() is meant for same string used in different contexts, e.g. _x( 'Add New', 'post' ) vs. _x( 'Add New', 'plugin' ), as it may require a different translation in each case.

Placeholders generally need a translator comment (/* translators: ... */), not a context.

Change History (1)

#1 @SergeyBiryukov
9 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 34921:

Customizer: Replace context for two strings added in [30306] with a translator comment.

Fixes #34203.

Note: See TracTickets for help on using tickets.