Add a Favorites Tab to the Add New Themes Page

[jeffr0]

The ability to mark themes as favorites in the WordPress theme directory was added three months ago ​https://meta.trac.wordpress.org/changeset/1770 Unlike the Add New Plugins page in the backend of WordPress, the Add Themes page does not have a Favorites tab to browse and install themes marked as Favorites. For consistency, I think Favorites should be added to the Add Themes page.

This screenshot is the Add Themes page in WordPress 4.4 Alpha
​https://cloudup.com/cN6rYpDiPUw

[swissspidy]

+1 for this. According to the themes_api docs querying favorites should already be possible.

[swissspidy]

34206.diff​ adds the "Favorites" tab to the theme installer.

The only thing missing is the form to enter your username if absent, like on the plugin install screen. Perhaps it doesn't make sense to have this form at two places though.

[DrewAPicture]

@swissspidy We're going to need the username field for this to be ready. Did you want to take a stab at it? 34206.diff​ still applies.

[swissspidy]

Yep, will look into it!

[swissspidy]

New favorites tab

[swissspidy]

New favorites tab with open filter view

[swissspidy]

34206.2.diff​ is a new patch that adds the username form as well.

Data is submitted via GET, just like on the plugin install screen. Because of that I needed to add a sort.split('&')[0] line to the sort method. Otherwise it would try to sort themes after favorites&user=<user>. Haven't found the proper way in the router to change that. It's not a big deal, but maybe someone wants to make this more beautiful.

[SergeyBiryukov]

Tested 34206.2.diff​:

• If I open the Favorites tab and then click on any other tab, the username input form does not disappear, because the .show-favorites-form class is never removed.
• Any chance to get rid of the page refresh when clicking Get Favorites? It could probably work the same way as the Apply Filters button on Feature Filter tab.

[swissspidy]

Replying to SergeyBiryukov:

• If I open the Favorites tab and then click on any other tab, the username input form does not disappear, because the .show-favorites-form class is never removed.

Argh, I could swear I've tested this.

• Any chance to get rid of the page refresh when clicking Get Favorites? It could probably work the same way as the Apply Filters button on Feature Filter tab.

That's what I first tried to implement, but I encountered problems with the request cache. Will look into it again though.

[swissspidy]

34206.3.diff​ is an updated patch that fixes the bug mentioned by @SergeyBiryukov and also uses Ajax to save the username.

Saving happens when clicking on the button or pressing enter. When saving was successful, a second query to browse the themes happens.

[SergeyBiryukov]

In 35527:

Themes: Add a Favorites tab to the Add Themes screen.

You can now browse and install your wordpress.org theme favorites from the theme installer, just like with plugins.

Props swissspidy.
Fixes #34206.

[pento]

In 35533:

Themes: Remove an errant comma from theme.js.

Added in [35527].

See #34206.

[ocean90]

In 35646:

Themes: Check if the browse view is set in wp_ajax_query_themes() to avoid a PHP notice when searching for new themes.

Introduced in [35527].

See #34206.

[ocean90]

In 35647:

Themes: Hide the favorites form when performing a search.

The search is global and ignores the user setting. Same for filters.

See #34206.