WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#34220 closed defect (bug) (fixed)

Update revision slider handle styling

Reported by: paulwilde Owned by: helen
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: Revisions Keywords: has-patch has-screenshots
Focuses: ui Cc:

Description

As the buttons are getting updated in #31459, it makes sense to also update the .wp-slider .ui-slider-handle used on the Revisions page.

Screenshot attached of the (current) version.

Attachments (4)

34220.png (7.9 KB) - added by paulwilde 6 years ago.
34220-update-revision-slider-1.diff (1.1 KB) - added by hugobaeta 6 years ago.
Updates slider handle to match normal buttons new style and makes it slightly larger
slider-update.png (6.9 KB) - added by hugobaeta 6 years ago.
Screenshot of update in patch 34220-update-revision-slider-1.diff
34220-update-revision-slider-2.diff (2.5 KB) - added by hugobaeta 6 years ago.
Updated patch, includes hover, and active states (lacking before), and removed from color schemes scss

Download all attachments as: .zip

Change History (13)

@paulwilde
6 years ago

This ticket was mentioned in Slack in #design by paulwilde. View the logs.


6 years ago

@hugobaeta
6 years ago

Updates slider handle to match normal buttons new style and makes it slightly larger

@hugobaeta
6 years ago

Screenshot of update in patch 34220-update-revision-slider-1.diff

#2 @hugobaeta
6 years ago

@paulwilde - Do you think the change to the gray colors makes sense, or out of scope? (and the only reason I made it slightly bigger was to balance the color change). Easily changeable to the primary button colors. I also haven't tested with color schemes.

#3 @paulwilde
6 years ago

I think the grey colour makes sense, at least to me.

It's more of a secondary action, whereas the primary action on the page is to "Restore This Autosave".

#4 @DrewAPicture
6 years ago

  • Component changed from General to Revisions
  • Focuses ui added

@hugobaeta
6 years ago

Updated patch, includes hover, and active states (lacking before), and removed from color schemes scss

#5 @adamsilverstein
6 years ago

@hugobaeta - this looks really nice, thanks!

Screencasts for the record:

Before:
http://cl.ly/image/3j3i2g2U1W3Y/Screen%20Recording%202015-10-08%20at%2003.54%20PM.gif

After, showing the hover and active states:
http://cl.ly/image/0u1V300R0n08/Screen%20Recording%202015-10-08%20at%2003.52%20PM.gif

#6 @DrewAPicture
6 years ago

  • Keywords has-patch has-screenshots added

#7 @melchoyce
6 years ago

Looks good to me.

#8 @helen
6 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 34976:

Revisions: Update slider handle styling.

This brings them in line with updated buttons as done in [34948] for #31459. It also gives it secondary action styling as opposed to primary, as restoring is considered the primary action.

props hugobaeta.
fixes #34220.

#9 @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 4.4
Note: See TracTickets for help on using tickets.