Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#34224 closed defect (bug) (fixed)

Pre-existing termmeta table not converted to utf8mb4 collation

Reported by: dboulet's profile dboulet Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.4
Component: Taxonomy Keywords: has-patch
Focuses: Cc:

Description

WordPress 4.4 introduces the termmeta database table, and also attempts to be accomodating of situations where this table was previously created—for example, by a plugin. The upgrade process properly updates the index on the pre-existing table to facilitate the move to utf8mb4, but doesn’t actually attempt to convert the table to the new collation. If the table was created prior to version 4.2, it will retain the old collation.

Attachments (2)

34224.patch (837 bytes) - added by dboulet 10 years ago.
34224-2.patch (1.2 KB) - added by dboulet 10 years ago.

Download all attachments as: .zip

Change History (7)

@dboulet
10 years ago

#1 @swissspidy
10 years ago

  • Keywords has-patch added

#2 @boonebgorges
10 years ago

  • Milestone changed from Awaiting Review to 4.4

Thanks very much for the ticket and the patch, dboulet.

Your fix looks right to me, but I'd like to get the AOK from Monsieur Pento before going with it.

#3 @pento
10 years ago

Yep, I'm cool with this patch.

Probably need to bump the $db_version, too, for those lucky people running trunk on their sites.

@dboulet
10 years ago

#4 @dboulet
10 years ago

Thank you boonebgorges and pento, I’ve attached a new patch.

#5 @SergeyBiryukov
10 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 34978:

After [34529], if a compatible termmeta table is found on database upgrade, convert it to utf8mb4 collation.

Props dboulet.
Fixes #34224.

Note: See TracTickets for help on using tickets.