Changes between Initial Version and Version 1 of Ticket #34233, comment 3
- Timestamp:
- 10/10/2015 03:08:44 PM (10 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #34233, comment 3
initial v1 22 22 I half agree, half disagree. 23 23 24 In this case it is appropriate for the custom fields to carry my `.prefix-hide_from_non_priv` class, since that's what I'm trying to hide. But the condition of the user not being a superadmin is a global condition. I wouldn't want to have to add thatto every element on the page where that status is relevant. It's much easier to have it as a body class. Indeed, I think there's a reason why core generally leans on body classes instead of putting classes like "home blog logged-in admin-bar" or "wp-admin wp-core-ui js" on every element where they're needed.24 In this case it is appropriate for the custom fields to carry my `.prefix-hide_from_non_priv` class, since that's what I'm trying to hide. But the condition of the user not being a superadmin is a global condition. I wouldn't want to have to add `.prefix-is_non_priv` to every element on the page where that status is relevant. It's much easier to have it as a body class. Indeed, I think there's a reason why core generally leans on body classes instead of putting classes like "home blog logged-in admin-bar" or "wp-admin wp-core-ui js" on every element where they're needed.