WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#34241 closed defect (bug) (fixed)

Press This: improve the "choose tags" button focus style

Reported by: afercia Owned by: afercia
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.3
Component: Press This Keywords: good-first-bug has-patch commit
Focuses: ui Cc:

Description (last modified by afercia)

The focus style on the "Choose from the most used tags" looks cut-off by the overflow: hidden set on its container. Playing with the button's padding/margin should be a simple fix.

https://cldup.com/Dc1GWQHwYJ.png

Attachments (3)

34241.diff (696 bytes) - added by adamholisky 5 years ago.
CSS fix for most used tags button in Press This
34241-after.jpg (10.7 KB) - added by adamholisky 5 years ago.
Screenshot of css fix
34241.2.diff (371 bytes) - added by afercia 5 years ago.

Download all attachments as: .zip

Change History (7)

#1 @afercia
5 years ago

  • Description modified (diff)

@adamholisky
5 years ago

CSS fix for most used tags button in Press This

@adamholisky
5 years ago

Screenshot of css fix

@afercia
5 years ago

#2 @afercia
5 years ago

  • Keywords has-patch commit added
  • Milestone changed from Awaiting Review to 4.4
  • Owner set to afercia
  • Status changed from new to assigned

Thanks very much @adamholisky. No need to patch the .rtl files, they're generated during the build process. Thinking it should look like all the other links, so I've tweaked a bit your patch.

https://cldup.com/FJqsgZMWQ5.png

This ticket was mentioned in Slack in #core by kraft. View the logs.


5 years ago

#4 @DrewAPicture
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

[35338] missed the ticket.

Note: See TracTickets for help on using tickets.