WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#34244 closed enhancement (fixed)

Remove orange hover link colour from Media Modal

Reported by: paulwilde Owned by: helen
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.4
Component: Media Keywords: has-patch has-screenshots
Focuses: ui, accessibility Cc:

Description

Some of the links in the Media Modal, such as the "Edit Image" link and the "Upload Files"/"Media Library" tabs have an orange hover colour that is not used anywhere else in core.

It might make sense to remove this colour and use the colour that pretty much every other link in core use.

Patch attached.

Attachments (6)

34244.diff (632 bytes) - added by paulwilde 5 years ago.
34244.2.diff (320 bytes) - added by paulwilde 5 years ago.
First patch had a change for another ticket.
default.png (10.4 KB) - added by swissspidy 5 years ago.
Default color of the link (no hover)
hover-old.png (13.2 KB) - added by swissspidy 5 years ago.
Old (current) hover color
hover-new.png (13.2 KB) - added by swissspidy 5 years ago.
New (proposed) hover color
34244.3.diff (708 bytes) - added by afercia 5 years ago.

Download all attachments as: .zip

Change History (12)

@paulwilde
5 years ago

#1 @paulwilde
5 years ago

  • Keywords has-patch added

@paulwilde
5 years ago

First patch had a change for another ticket.

@swissspidy
5 years ago

Default color of the link (no hover)

@swissspidy
5 years ago

Old (current) hover color

@swissspidy
5 years ago

New (proposed) hover color

#2 follow-up: @swissspidy
5 years ago

  • Focuses accessibility removed
  • Keywords has-screenshots added
  • Milestone changed from Awaiting Review to 4.4

It's worth noting that the color #d54e21 itself is used quite often in core, but usually part of the color scheme.

It makes sense to remove it in this case.

#3 @wonderboymusic
5 years ago

  • Owner set to helen
  • Status changed from new to reviewing

because I would ask you anyways

#4 in reply to: ↑ 2 @helen
5 years ago

Replying to swissspidy:

It's worth noting that the color #d54e21 itself is used quite often in core, but usually part of the color scheme.

It makes sense to remove it in this case.

I think we need to redefine it to match the lighter blue used in the admin and not just remove it, since media can be used on the front-end and it would be best to avoid having it just inherit whatever the theme has. I'm not sure how much we really prevent that right now, so it's worth checking. It also seems like we need to update some colors in the media CSS generally, by the way - I'll open another ticket for that.

Just for history, #d54e21 is the "old" WP orange accent color that we've mostly gotten rid of but have kept around in some places. It shouldn't be a link hover color anymore though, so good catch.

@afercia
5 years ago

#5 @afercia
5 years ago

  • Focuses accessibility added

Refreshed patch. Tried to use the same colors used in common.css. Also, the box-shadow for the focus style was inherited from common.css so (I think) not available when the Media Modal is used on the front-end.
If we want to restrict these styles to the media modal, wondering if it would be better to use .media-modal instead of .media-frame.

Since the current orange doesn't provide a sufficient color contrast ratio, I'd propose to consider this ticket a bug :)

#6 @helen
5 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 35330:

Media: Update colors to match the times.

This bikeshed is a real nice blue.

props afercia.
fixes #34244. see #34388.

Note: See TracTickets for help on using tickets.