Remove orange hover link colour from Media Modal

[paulwilde]

Some of the links in the Media Modal, such as the "Edit Image" link and the "Upload Files"/"Media Library" tabs have an orange hover colour that is not used anywhere else in core.

It might make sense to remove this colour and use the colour that pretty much every other link in core use.

Patch attached.

[paulwilde]

First patch had a change for another ticket.

[swissspidy]

Default color of the link (no hover)

[swissspidy]

Old (current) hover color

[swissspidy]

New (proposed) hover color

[swissspidy]

It's worth noting that the color #d54e21 itself is used quite often in core, but usually part of the color scheme.

It makes sense to remove it in this case.

[wonderboymusic]

because I would ask you anyways

[helen]

Replying to swissspidy:

It's worth noting that the color #d54e21 itself is used quite often in core, but usually part of the color scheme.

It makes sense to remove it in this case.

I think we need to redefine it to match the lighter blue used in the admin and not just remove it, since media can be used on the front-end and it would be best to avoid having it just inherit whatever the theme has. I'm not sure how much we really prevent that right now, so it's worth checking. It also seems like we need to update some colors in the media CSS generally, by the way - I'll open another ticket for that.

Just for history, #d54e21 is the "old" WP orange accent color that we've mostly gotten rid of but have kept around in some places. It shouldn't be a link hover color anymore though, so good catch.

[afercia]

Refreshed patch. Tried to use the same colors used in common.css. Also, the box-shadow for the focus style was inherited from common.css so (I think) not available when the Media Modal is used on the front-end.
If we want to restrict these styles to the media modal, wondering if it would be better to use .media-modal instead of .media-frame.

Since the current orange doesn't provide a sufficient color contrast ratio, I'd propose to consider this ticket a bug :)

[helen]

In 35330:

Media: Update colors to match the times.

This bikeshed is a real nice blue.

props afercia.
fixes #34244. see #34388.