WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#34250 closed defect (bug) (fixed)

Customizer: Change File x Change Image

Reported by: pavelevap's profile pavelevap Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.4
Component: Customize Keywords: has-patch
Focuses: Cc:

Description

For Site Icon there is button "Change File" (and related strings in modal window).

For Background Image there is button "Change Image".

But Site Icon can be only image, so it should be the same button "Change Image", I guess.

Attachments (1)

34250.diff​ (619 bytes) - added by paulwilde 10 years ago.

Download all attachments as: .zip

Change History (4)

@paulwilde
10 years ago

#1 @paulwilde
10 years ago

  • Keywords has-patch added

Agreed.

#2 @SergeyBiryukov
10 years ago

  • Milestone changed from Awaiting Review to 4.4

#3 @SergeyBiryukov
10 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 35018:

Customizer: WP_Customize_Cropped_Image_Control should extend WP_Customize_Image_Control, since Site Icon can only an image.

Props paulwilde.
Fixes #34250.

Note: See TracTickets for help on using tickets.