WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#34250 closed defect (bug) (fixed)

Customizer: Change File x Change Image

Reported by: pavelevap Owned by: SergeyBiryukov
Priority: normal Milestone: 4.4
Component: Customize Version: 4.4
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

For Site Icon there is button "Change File" (and related strings in modal window).

For Background Image there is button "Change Image".

But Site Icon can be only image, so it should be the same button "Change Image", I guess.

Attachments (1)

34250.diff​ (619 bytes ) - added by paulwilde 11 years ago.

Download all attachments as: .zip

Change History (4)

@paulwilde
11 years ago

#1 @paulwilde
11 years ago

  • Keywords has-patch added

Agreed.

#2 @SergeyBiryukov
11 years ago

  • Milestone Awaiting Review → 4.4

#3 @SergeyBiryukov
11 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 35018:

Customizer: WP_Customize_Cropped_Image_Control should extend WP_Customize_Image_Control, since Site Icon can only an image.

Props paulwilde.
Fixes #34250.

Note: See TracTickets for help on using tickets.