WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#34264 closed defect (bug) (fixed)

Don't use a variable for the `do_feed_{feed}` action name

Reported by: johnbillion's profile johnbillion Owned by: drewapicture's profile DrewAPicture
Milestone: 4.4 Priority: normal
Severity: normal Version: 2.1
Component: Feeds Keywords: has-patch
Focuses: docs Cc:

Description

The do_feed_{feed} action uses a variable for the whole of its name which means ​no results show up for it in the code reference.

Attachments (1)

34264.diff​ (707 bytes) - added by johnbillion 10 years ago.

Download all attachments as: .zip

Change History (5)

@johnbillion
10 years ago

#1 @johnbillion
10 years ago

  • Keywords has-patch added
  • Owner set to DrewAPicture
  • Status changed from new to assigned

@DrewAPicture 34264.diff​ should fix it, no?

#2 @DrewAPicture
10 years ago

  • Status changed from assigned to reviewing

#3 @DrewAPicture
10 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 35097:

Feeds: Adjust the do_feed_{$feed} hook name to actually be dynamic, rather than pre-storing the tag name in a variable and referencing that.

Props johnbillion.
Fixes #34264.

#4 @DrewAPicture
10 years ago

In 35098:

Feeds: Simplify logic for checking if the do_feed_{$feed} action is hooked to any callbacks.

See [35097] for where the aforementioned hook was renamed to actually be dynamic, thus rendering creation of the extra $hook variable moot.

See #34264.

Note: See TracTickets for help on using tickets.