Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 8 years ago

#34265 closed defect (bug) (fixed)

#a11y-headings - the Updates screen

Reported by: afercia's profile afercia Owned by: afercia's profile afercia
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.3
Component: Administration Keywords: has-patch has-screenshots
Focuses: ui, accessibility Cc:

Description (last modified by afercia)

In the Updates screen, while the update process is running, some headings appear, one for each updated item:

https://cldup.com/q6krS2Pt-N.png

These headings are currently <h4> so there are two missing levels, however they're inside an iframe which, technically, is a separated document.
Wondering what to do here, would changing them in <h2> be correct?

#a11y-headings

Attachments (2)

34265.patch (1.7 KB) - added by afercia 10 years ago.
34265.2.patch (1.8 KB) - added by afercia 10 years ago.

Download all attachments as: .zip

Change History (10)

@afercia
10 years ago

#1 @afercia
10 years ago

  • Keywords has-patch added

The attached patch changes these headings in <h2>, waiting for some feedback tough.

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


10 years ago

#3 @afercia
10 years ago

  • Owner set to afercia
  • Status changed from new to assigned

@afercia
10 years ago

#4 @afercia
10 years ago

  • Keywords has-screenshots added

Refreshed patch to take care of the headings also when updating translations (or core):

https://cldup.com/kSFlSfog_R.png

#5 @afercia
10 years ago

  • Description modified (diff)

#6 @afercia
10 years ago

We've discussed a bit this ticket in our last accessibility team chat on Slack, for a more proper semantic all the updated items should be probably marked up as list items. After all this is a list, even when there's just one update.
By the way there are many things running here: PHP output buffering, error handling, inline JavaScript, etc. I'd be inclined to keep it simple and just change the headings level.

#7 @afercia
10 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 35219:

Bump H4 headings to H2 in the Updates screen for better accessibility.

Fixes #34265.

This ticket was mentioned in Slack in #core by pento. View the logs.


8 years ago

Note: See TracTickets for help on using tickets.