WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#34268 closed defect (bug) (wontfix)

about.php page spelling mistake and wrong screenshot

Reported by: umesh.nevase Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.3
Component: Upgrade/Install Keywords: has-screenshots has-patch
Focuses: docs Cc:
PR Number:

Description

I've updated wordpress to 4.3.1, I've found some issue on wp-admin/about.php
1) 's' is missing after apostrophe in 'Better Passwords' box.
2) Screenshot of 'Better Passwords' is different that actual implementation.

Attachments (3)

about-updated-edited.png (116.1 KB) - added by umesh.nevase 4 years ago.
Screenshot of issues
34268.diff (1.1 KB) - added by umesh.nevase 4 years ago.
patch file for spelling mistake
about-page-update.png (20.5 KB) - added by umesh.nevase 4 years ago.
Screenshot should be like this

Download all attachments as: .zip

Change History (10)

@umesh.nevase
4 years ago

Screenshot of issues

@umesh.nevase
4 years ago

patch file for spelling mistake

@umesh.nevase
4 years ago

Screenshot should be like this

#1 @umesh.nevase
4 years ago

  • Keywords has-screenshots has-patch added

#2 follow-up: @helen
4 years ago

  • Keywords close added

Thanks for the detailed report!

  1. An extra s after an apostrophe is not required on words that end with s - as far as I've ever learned, there are no real rules around this. However, because in speaking I imagine most people would pronounce the extra syllable (as in "WordPress-es"), we should probably use WordPress's in the future. I'm not sure it's worth fixing this for point releases, though.
  2. The screenshot is accurate for narrow viewports, and I think looks better in the limited space that's there so you see more of what's really relevant.

#3 follow-up: @SergeyBiryukov
4 years ago

From http://www.grammarbook.com/punctuation/apostro.asp:

Rule 1c. Some writers and editors add only an apostrophe to all nouns ending in s. And some add an apostrophe + s to every proper noun, be it Hastings's or Jones's.

One method, common in newspapers and magazines, is to add an apostrophe + s (​'s) to common nouns ending in s, but only a stand-alone apostrophe to proper nouns ending in s.

Examples:
the class's hours
Mr. Jones' golf clubs
the canvas's size
Texas' weather

Care must be taken to place the apostrophe outside the word in question. For instance, if talking about a pen belonging to Mr. Hastings, many people would wrongly write Mr. Hasting's pen (his name is not Mr. Hasting).

Correct: Mr. Hastings' pen

Another widely used technique is to write the word as we would speak it. For example, since most people saying, "Mr. Hastings' pen" would not pronounce an added s, we would write Mr. Hastings' pen with no added s. But most people would pronounce an added s in "Jones's," so we'd write it as we say it: Mr. Jones's golf clubs. This method explains the punctuation of for goodness' sake.

Last edited 4 years ago by SergeyBiryukov (previous) (diff)

#4 in reply to: ↑ 2 @umesh.nevase
4 years ago

@helen

I was unclear about apostrophe for words ends with s.

The screenshots in other boxes are of larger viewports and only for 'Better Passwords' box it is of narrow viewports. I think we should display all screenshots of larger viewports or of narrow viewports.

Replying to helen:

Thanks for the detailed report!

  1. An extra s after an apostrophe is not required on words that end with s - as far as I've ever learned, there are no real rules around this. However, because in speaking I imagine most people would pronounce the extra syllable (as in "WordPress-es"), we should probably use WordPress's in the future. I'm not sure it's worth fixing this for point releases, though.
  2. The screenshot is accurate for narrow viewports, and I think looks better in the limited space that's there so you see more of what's really relevant.

#5 in reply to: ↑ 3 @umesh.nevase
4 years ago

@SergeyBiryukov

Thank you for reference link.

Replying to SergeyBiryukov:

From http://www.grammarbook.com/punctuation/apostro.asp:

Rule 1c. Some writers and editors add only an apostrophe to all nouns ending in s. And some add an apostrophe + s to every proper noun, be it Hastings's or Jones's.

One method, common in newspapers and magazines, is to add an apostrophe + s (​'s) to common nouns ending in s, but only a stand-alone apostrophe to proper nouns ending in s.

Examples:
the class's hours
Mr. Jones' golf clubs
the canvas's size
Texas' weather

Care must be taken to place the apostrophe outside the word in question. For instance, if talking about a pen belonging to Mr. Hastings, many people would wrongly write Mr. Hasting's pen (his name is not Mr. Hasting).

Correct: Mr. Hastings' pen

Another widely used technique is to write the word as we would speak it. For example, since most people saying, "Mr. Hastings' pen" would not pronounce an added s, we would write Mr. Hastings' pen with no added s. But most people would pronounce an added s in "Jones's," so we'd write it as we say it: Mr. Jones's golf clubs. This method explains the punctuation of for goodness' sake.

#6 @swissspidy
4 years ago

I think we should display all screenshots of larger viewports or of narrow viewports.

Still something I wouldn't fix in a point release. Especially since the image is cached on the CDN and very few people would see the changed image. Plus, the current screenshot really looks better.

+1 for closing

#7 @SergeyBiryukov
4 years ago

  • Keywords close removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.