WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#34276 closed defect (bug) (fixed)

Missing number i18n in the embed template

Reported by: johnbillion's profile johnbillion Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.4
Component: Embeds Keywords: has-patch commit
Focuses: Cc:

Description

wp-includes/embed-template.php casts the comment number to an integer instead of internationalising it.

Attachments (1)

34276.diff​ (485 bytes) - added by johnbillion 9 years ago.

Download all attachments as: .zip

Change History (4)

@johnbillion
9 years ago

#1 @johnbillion
9 years ago

  • Keywords has-patch commit added

Just needs a sanity check.

#2 @DrewAPicture
9 years ago

@johnbillion Looks good.

#3 @SergeyBiryukov
9 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 35096:

Format the number of comments in wp-includes/embed-template.php for the locale.

Props johnbillion.
Fixes #34276.

Note: See TracTickets for help on using tickets.