WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#34280 closed defect (bug) (fixed)

Remove usage of the `wpurl` blog option

Reported by: johnbillion Owned by: SergeyBiryukov
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch commit dev-feedback
Focuses: Cc:

Description

There are two instances in core where get_bloginfo( 'wpurl' ) is used, one of which is incorrect and should use admin_url(), and another which should use site_url().

Attachments (1)

34280.diff (2.8 KB) - added by johnbillion 4 years ago.

Download all attachments as: .zip

Change History (6)

@johnbillion
4 years ago

#1 @johnbillion
4 years ago

  • Keywords has-patch commit dev-feedback added

34280.diff corrects the following:

  • Potentially incorrect scheme for the application/rsd+xml link URL.
  • Potentially incorrect scheme and/or incorrect URL for the plugin editor error scraping iframe.
  • URL generation for the plugin activation error scraping iframe, just for parity with the above.

Just needs a sanity check.

#2 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#3 @SergeyBiryukov
4 years ago

In 35105:

Replace get_bloginfo( 'wpurl' ) with site_url() in rsd_link().

Ensure the correct scheme is used for the application/rsd+xml link URL.

Props johnbillion.
See #34280.

#4 @SergeyBiryukov
4 years ago

In 35107:

Replace get_bloginfo( 'wpurl' ) with admin_url() in plugin editor.

Use add_query_arg() instead of constructing the URL manually.

Props johnbillion.
See #34280.

#5 @SergeyBiryukov
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 35109:

Replace get_bloginfo( 'wpurl' ) with admin_url() for plugin activation error message.

Use add_query_arg() instead of constructing the URL manually.

Props johnbillion.
Fixes #34280.

Note: See TracTickets for help on using tickets.