#a11y-headings - the Theme Browser modal dialog headings

[afercia]

The Theme Browser modal dialog uses some headings for the "Theme name", "By author", and for the "Update Available" notice. See screenshot below:

While the headings hierarchy is formally correct (there are no skipped levels), headings should preferably be used to mark sections with some content.

Specifically, I'm not sure the "By author" should be a heading in the first place and the update notice shouldn't be a sub-heading under the "By author" H3.

I'd propose to change "By author" in a paragraph and bump up the update notice from H4 to H3.

Please notice there's an ongoing discussion in the accessibility team about the first heading within modal dialogs. We're currently investigating if it should be a H1, but this issue would need its own separate ticket.

#a11y-headings

[afercia]

The proposed patch tries to improve semantics for the main elements in the Theme Browser dialog, changing "By author" in a paragraph and bumping up the Update notice from a H4 to a H3 heading. As far as I see there are no visual changes.

[rianrietveld]

+1

[afercia]

In 35220:

Accessibility: Improve headings hierarchy in the Theme browser modal dialog.

Fixes #34288.