WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#34289 closed defect (bug) (fixed)

#a11y-headings - the Quick Edit and Bulk Edit headings

Reported by: afercia Owned by: afercia
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.3
Component: Administration Keywords: has-patch has-screenshots commit
Focuses: ui, accessibility Cc:
PR Number:

Description

The Quick Edit and Bulk Edit forms currently use a H4 heading, see for example the headings hierarchy in the Posts and Categories screens in the screenshot below:

https://cldup.com/p1BetV3LS5.png

They probably shouldn't be headings in the first place. As far as I see, they're already within a <fieldset> element so changing them in <legend> elements seems to me the most appropriate thing to do.

Any thoughts (and patch) more than welcome :)

#a11y-headings

Attachments (2)

34289.patch (2.6 KB) - added by afercia 4 years ago.
34289.2.patch (2.7 KB) - added by afercia 4 years ago.

Download all attachments as: .zip

Change History (11)

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


4 years ago

@afercia
4 years ago

#2 @afercia
4 years ago

  • Keywords has-patch needs-screenshots added

First pass. Since the legend position is a bit tricky in IE, would need some testing in that browser(s). cc @Cheffheid :) Will upload screenshots later.

#3 @afercia
4 years ago

  • Owner set to afercia
  • Status changed from new to assigned

@afercia
4 years ago

#4 @afercia
4 years ago

Refreshed patch to use a more specific CSS selector and avoid conflicts with other legends, see:

https://cldup.com/VPM44MAgLt.png

#5 @afercia
4 years ago

  • Keywords has-screenshots commit added; needs-screenshots removed

Side by side comparison, before (left) and after (right):

https://cldup.com/BfZtojoHAV.png

#6 @SergeyBiryukov
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 35234:

Replace Quick Edit and Bulk Edit headings with <legend> elements.

Props afercia.
Fixes #34289.

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


4 years ago

This ticket was mentioned in Slack in #core by afercia. View the logs.


4 years ago

This ticket was mentioned in Slack in #design by afercia. View the logs.


4 years ago

Note: See TracTickets for help on using tickets.