WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #34290, comment 15


Ignore:
Timestamp:
04/23/2018 09:48:43 AM (18 months ago)
Author:
aristath
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #34290, comment 15

    v1 v2  
    2020}}}
    2121
    22 f we don't want to strip `%` symbols then checking for `%s` before `sprintf` looks like a reasonable and safe solution. This way `sprintf` will only run if we've got a syntax where it actually makes sense to use `sprintf`. Otherwise this is a really annoying bug...
     22f we don't want to strip `%` symbols then checking for `%s`, `%1$s` and `%2$s` before `sprintf` looks like a reasonable and safe solution. This way `sprintf` will only run if we've got a syntax where it actually makes sense to use `sprintf`. Otherwise this is a really annoying bug...