WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #34290, comment 7


Ignore:
Timestamp:
04/05/2016 10:32:30 PM (4 years ago)
Author:
kuus
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #34290, comment 7

    initial v1  
    1 the [https://github.com/WordPress/WordPress/commit/fb64ee90ef2a1da4b568e4ca7f22e0771f3d8660#diff-931d58e88156d7984f7c387d069a8082R429 commit] that introduced the {{{get_theme_mod}}} function and the [https://github.com/WordPress/WordPress/blob/fb64ee90ef2a1da4b568e4ca7f22e0771f3d8660/wp-includes/theme.php theme.php] at that time.
     1@davetgreen I don't think the regex is the way to go, because the percent symbol could be anywhere in a string, it does not necessarily comes after a number.
     2
     3I did a bit of research in the codebase to see where this {{{sprintf}}} was introduced and it seems since the beginning (2007)...here the [https://github.com/WordPress/WordPress/commit/fb64ee90ef2a1da4b568e4ca7f22e0771f3d8660#diff-931d58e88156d7984f7c387d069a8082R429 commit] that introduced the {{{get_theme_mod}}} function and the [https://github.com/WordPress/WordPress/blob/fb64ee90ef2a1da4b568e4ca7f22e0771f3d8660/wp-includes/theme.php theme.php] at that time.
    24@matt it seems that you wrote that function (not sure if you are the same Matt though)
    35I am still wondering why this {{{sprintf}}}, it seems to me that we could just get rid of it and solve the bug this way..what do you think?