Session storage autosave notice displayed in the wrong place

[afercia]

The main heading in the admin screens is now a H1 and we missed to update the jQuery selector used for appending the Session storage autosave notice. It's still $('.wrap h2').first() so the notice gets appended after the first H2 in the page :)

[afercia]

In the proposed patch:

• After [32974], use a proper jQuery selector for the session storage autosave notice.

[afercia]

Screenshot with patch applied:

[afercia]

As per @iseulde suggestion, will try to use $( '#post' ).before() in a new patch, Side note, will try to do the same for the back-compat in common.js introduced in [32974], will open a separate ticket.

[afercia]

Refreshed patch to use better jQuery, previous implementation:

$( '.wrap h1' ).first().after( $notice.addClass( 'notice-warning' ).show() );

new one:

$( '#post' ).before( $notice.addClass( 'notice-warning' ).show() );

Any thoughts and testing more than welcome :)

[iseulde]

Don't think we need to exclude the ones that are already correctly positioned, it makes the query easier.

[afercia]

@iseulde your approach makes sense but I'm afraid it will work just on some admin screens. Plugins may have screens where the first form element inside .wrap is not exactly in the place you would expect :(

[afercia]

I'd propose to split the issues and keep this ticket just for the session storage notice. Since it's used when editing posts, I think we can rely on the presence of $( '#post' ) ? Any thoughts welcome.

[iseulde]

In 35238:

Admin: fix repositioning notices

Fixes #34294.
Props afercia.

[stephenharris]

The current patch breaks backwards compatibility with plug-ins using .below-h2 class to keep alerts in-line.

Since we're using H1 tags for pages and not H2 the class .below-h2 doesn't make much sense - but I just wanted to raise the above compatibility issue in case the break was unintentional. We could exclude divs with .inline or .below-h2.

Any thoughts?

[afercia]

In 35516:

Admin: Ensure notices with the below-h2 class are not repositioned after [35238].

Keeps the .below-h2 class for backwards compatibility with plugins that are (incorrectly) using it. Plugins should use .inline instead.

Props stephenharris.
Fixes #34570. See #34294.