Twenty Sixteen as default theme
|Reported by:||SergeyBiryukov||Owned by:||helen|
Per previous Slack discussions, Twenty Sixteen will not be merged to SVN, but should be a default theme for new installs:
matt: what's the advantage of having 2016 in core at all?
matt: can't we just have the bundling be a packaging thing, vs a monolithic SVN thing
otto42: like, code in the upgrade process to auto-install the theme if its not there?
otto42: from themes dir
matt: don't even need to, people who want it can get it from the directory
matt: it's really more for brand new users doing one-clicks or downloads
ocean90: If we ship Twenty Sixteen with with core I'm fine with adding the people to the credits file. But we should test this a bit since there are some tests re WP_DEFAULT_THEME.
dd32: We’re going to have some issues with the WP_DEFAULT_THEME constant with Twenty Sixteen NOT as part of svn, and that’s expected because we can’t expect it’s installed on all sites (Especially ones which have just upgraded). What this effectively means is we have to stop using the constant.. But the constant exists because of bad hosts we couldn’t rely upon a non-constant method..
dd32: What we really need to do is to ship-with/have-in-svn one theme that’s always there (WP_DEFAULT_THEME) and have the default theme for new installs not based on WP_DEFAULT_THEME but rather based on a hard-coded ‘twentysixteen’ in the setup options.. That then has implications for Multisite though.. where WP_DEFAULT_THEME might be custom defined to something else.
Previously, all bundled themes were merged into SVN, so we should figure out the process for Twenty Sixteen, both in terms of how this is going to work for SVN and built packages, and giving credit to the theme contributors.
For reference, here's the list of things that needed to change when new default themes were merged in the past.
Change History (29)
- Owner set to helen
- Resolution set to fixed
- Status changed from assigned to closed