WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#34318 closed enhancement (fixed)

Descriptive error message for deprecated argument for get_categories function

Reported by: gagan0123 Owned by: DrewAPicture
Milestone: 4.4 Priority: normal
Severity: minor Version: 4.4
Component: Taxonomy Keywords: has-patch
Focuses: Cc:

Description

When someone uses the argument

type=link

WordPress throws a generic argument deprecated error message without stating which one. With this patch it gives the exact message and how to resolve it.

Attachments (4)

category_error_message.patch (534 bytes) - added by gagan0123 5 years ago.
Patch for the corresponding ticket
34318.diff (644 bytes) - added by swissspidy 5 years ago.
34318_multiple_files.patch (1.2 KB) - added by gagan0123 5 years ago.
Found that the same issue was there in another file as well, made patch with swissspidy's correction for both places
34318_multiple_files_V2.patch (1.3 KB) - added by gagan0123 5 years ago.
Found the wordings swissspidy used a bit misleading, changed it to a bit more specific

Download all attachments as: .zip

Change History (7)

@gagan0123
5 years ago

Patch for the corresponding ticket

#1 @gagan0123
5 years ago

  • Keywords has-patch added
  • Severity changed from normal to minor

@swissspidy
5 years ago

#2 @swissspidy
5 years ago

  • Milestone changed from Awaiting Review to 4.4

34318.diff is an updated patch with refined wording and proper i18n.

@gagan0123
5 years ago

Found that the same issue was there in another file as well, made patch with swissspidy's correction for both places

@gagan0123
5 years ago

Found the wordings swissspidy used a bit misleading, changed it to a bit more specific

#3 @DrewAPicture
5 years ago

  • Owner set to DrewAPicture
  • Resolution set to fixed
  • Status changed from new to closed

In 35264:

Taxonomy: Improve deprecated argument strings for the 'link' type in get_categories() and wp_dropdown_categories().

Props swissspidy, gagan0123.
Fixes #34318.

Note: See TracTickets for help on using tickets.