WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#34321 closed defect (bug) (fixed)

Embed service CSS does not load in src if WP_DEBUG is not set

Reported by: peterwilsoncc's profile peterwilsoncc Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: Embeds Keywords: has-patch
Focuses: Cc:

Description

Running wordpress-develop.dev from the source directory does not load the CSS in the iframe is WP_DEBUG is not set to true.

Possible solutions:

  • the condition in print_oembed_embed_styles requires a check for $develop_src
  • the WP_DEBUG default should be do a check similar to SCRIPT_DEBUG
  • new global: STYLE_DEBUG

Attachments (1)

34321.diff​ (759 bytes) - added by MikeHansenMe 10 years ago.

Download all attachments as: .zip

Change History (6)

#1 @peterwilsoncc
10 years ago

  • Component changed from General to Embeds

#2 @SergeyBiryukov
10 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.4

#3 @swissspidy
10 years ago

SCRIPT_DEBUG works for scripts and styles and should be used accordingly. So let's replace the WP_DEBUG check with SCRIPT_DEBUG in print_oembed_embed_styles().

@MikeHansenMe
10 years ago

#4 @MikeHansenMe
10 years ago

  • Keywords has-patch added; needs-patch removed

#5 @SergeyBiryukov
10 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 35228:

Embeds: In print_oembed_embed_styles(), load non-minified file if SCRIPT_DEBUG is true.

This is consistent with print_oembed_embed_scripts().

Props MikeHansenMe.
Fixes #34321.

Note: See TracTickets for help on using tickets.