Default option for site_icon

[sebastian.pisula]

If Default Icon is not defined then insert default option.

[sebastian.pisula]

if option not exists then wordpress send request to mysql all the time:

SELECT option_value FROM wp_options WHERE option_name = 'site_icon' LIMIT 1

in my opinion unnecessary query

[swissspidy]

Can you explain why this should be needed? update_blog_option would result in an additional, unneeded database query just so that there's a 0.

If you want a different default value, we could pass that as the second argument to get_option.

Also, why is SELECT option_value FROM wp_options WHERE option_name = 'site_icon' LIMIT 1 unnecessary? I mean, somehow we need to get that option from the database…

[johnbillion]

This is valid. Same problem as #26876.

[swissspidy]

34339.2.patch​ adds little coding standards improvements.

Works great so far.

[ocean90]

Shouldn't site_icon be added to populate_options()?

[swissspidy]

Replying to ocean90:

Shouldn't site_icon be added to populate_options()?

D'oh, that makes more sense :)

@sebastian.pisula: Thanks for the updated patch! Note that we use 4.4.0 instead of 4.4 for docs. Also, you mixed up the indentation in your patch (spaces vs. tabs).

Ps. Trac doesn't send notifications for new attachments. I usually write something afterwards to notify people.

[obenland]

Since it holds a post id, it should probably be an int. We can also just add it to the 4.3 part, it was introduced back then.

[swissspidy]

34339.7.diff​ makes 0 the default.

[wonderboymusic]

In 35312:

Site Icon: make the default value for the site_icon option 0 in schema.php.

Props swissspidy, sebastian.pisula.
Fixes #34339.