Menu Customizer: Large space above delete button

[pavelevap]

See attached screenshot. It is probably caused by hidden spinner...

[afercia]

Can confirm it's a hidden spinner. Any translated strings longer than the English ones will probably trigger this "float drop":

I'm not even sure why there's a spinner there in the first place.

[xavortm]

I think the way it is now is better, since when the spinner becomes visible it wont jump down + there is better separation for different action areas (add and delete)

[afercia]

Couldn't find any workflow where this add-menu-item-loading spinner is actually used and gets visible. Maybe it should be simply removed? cc @ocean90 @celloexpressions

[westonruter]

@afercia right, I think the add-menu-item-loading spinner is for some legacy code for when originally an Ajax request was needed when adding a new menu item. Now, however, it is all handled in Javascript so there is no need for a spinner when adding a new menu item since it is instant.

[dipali.dhole27@…]

@afercia , @westonruter: I browsed through the site files and found that the mentioned hidden spinner is not being used anywhere. Also, as mentioned by @westonruter that we do not need the hidden spinner any more. Below I am attaching the patch for the same with the hidden spinner removed.

[afercia]

In 35396:

Customizer: Remove the no more used add-menu-item-loading spinner.

Also makes more room for longer translations.

Props dipali.dhole27@….
Fixes #34342.