WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#34345 closed defect (bug) (fixed)

Document PHPStorm .idea ignore in .gitignore and svn:ignore

Reported by: netweb Owned by: johnbillion
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description

PhpStorm uses an .idea folder in the root folder to store project configuration etc.

Ignoring this folder in .gitignore is helpful for people using the PhpStorm IDE.

This change actually snuck in under the radar via r35242.

I see no real problems in keeping this, though it should be moved toward the bottom of the .gitignore file and also added to the svn:ignore properties for VCS configuration parity.

Attachments (1)

34345.diff (307 bytes) - added by nerrad 4 years ago.
document .idea addition to .gitignore and relocate to end of file.

Download all attachments as: .zip

Change History (7)

#1 follow-up: @nerrad
4 years ago

woops that's my fault! I should have mentioned something accompanying the patch I submitted. Sorry 'bout that.

@nerrad
4 years ago

document .idea addition to .gitignore and relocate to end of file.

#2 @johnbillion
4 years ago

  • Milestone changed from Awaiting Review to 4.4
  • Owner set to johnbillion
  • Status changed from new to accepted

IDE-specific .gitignore rules should not be present in a project. They should be managed in the user's ~/.gitignore_global.

#3 @nerrad
4 years ago

  • Keywords has-patch added; needs-patch removed

I documented and relocated in the .gitignore file. However, I don't do WP contributions via svn (just doing git right now) and really don't want to checkout the svn repo so if someone could take care of the svn:ignore that would rock.

#4 @johnbillion
4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 35254:

Remove an IDE-specific rule in .gitignore. These should be managed in the user's ~/.gitignore_global file.

Fixes #34345

#5 @nerrad
4 years ago

#facepalm of course!

#6 in reply to: ↑ 1 @netweb
4 years ago

Thanks John, hadn't thought about that's really where these ignores should be made :)

Last edited 4 years ago by netweb (previous) (diff)
Note: See TracTickets for help on using tickets.